Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in to Moodle as a student
      2. Go to Navigation > Site pages > Calendar.
      3. Click the button 'Manage subscriptions'.
      4. Try importing a calendar with the URL webcal://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics , no errors should be generated
      5. Try importing a calendar with the URL webcal://www.mozilla.org/proj{}ects/calendar/caldata/AustraliaHolidays.ics , "invalid url" errors should be generated
      6. Try importing a calendar with the URL http://www.mozi{}lla.org/projects/calendar/caldata/AustraliaHolidays.ics , "invalid url" errors should be generated
      7. Try importing a calendar with the URL http://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics , no errors should be generated
      8. Make sure all urls (the ones with no error) are stored as "http" not "Webcal"
      9. make sure the events are created in the calendar as expected.
      Show
      Log in to Moodle as a student Go to Navigation > Site pages > Calendar. Click the button 'Manage subscriptions'. Try importing a calendar with the URL webcal://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics , no errors should be generated Try importing a calendar with the URL webcal://www.mozilla.org/proj{}ects/calendar/caldata/AustraliaHolidays.ics , "invalid url" errors should be generated Try importing a calendar with the URL http://www.mozi {}lla.org/projects/calendar/caldata/AustraliaHolidays.ics , "invalid url" errors should be generated Try importing a calendar with the URL http://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics , no errors should be generated Make sure all urls (the ones with no error) are stored as "http" not "Webcal" make sure the events are created in the calendar as expected.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-36526-master

      Description

      If you try to import an external calendar with the following URL...

      webcal://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics

      The form validation regards this as an invalid URL and prompts the user for another.

      Replication steps:

      1. Log in to Moodle as a student
      2. Go to Navigation > Site pages > Calendar.
      3. Click the button 'Manage subscriptions'.
      4. Try importing a calendar with the URL webcal://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics

      Expected result: The file should be used as the basis of a calendar

      Actual result: Validation fails and user is asked to enter another URL

      Note that the calendar import does accept the same URL with the http protocol.

      http://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics

      The problem is that the field for the calendar URL has the type PARAM_URL, which accepts only http, https, mailto and ftp.

      The best solution would be to create some custom validation for this field that checks, if the text does not qualify using PARAM_URL, that it begins with webcal:// and the rest is a valid URL (perhaps substitute webcal for http and test).

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12