Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36538

Webdav repository runs out of memory with large files

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Set up a webdav repository
      2. Add a large file (e.g. > 50Mb) to the webdav folder
      3. Make sure the file limits for your test course are greater than the size of the large file
      4. Add a new file resource to a course
      5. On the settings page, click 'Add' on the filemanager
      6. Attempt to add the large file to the filemanager via the webdav repository

      Expected result - the large file can be added successfully.

      Show
      Set up a webdav repository Add a large file (e.g. > 50Mb) to the webdav folder Make sure the file limits for your test course are greater than the size of the large file Add a new file resource to a course On the settings page, click 'Add' on the filemanager Attempt to add the large file to the filemanager via the webdav repository Expected result - the large file can be added successfully.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-36538_webdav_memory

      Description

      As the webdav repository downloads the entire file into memory, before writing it out to a local file, large files can cause 'out of memory' errors.

      I will submit a patch, in a moment, that writes each downloaded chunk directly to a local file, removing the large file limit.

        Attachments

          Activity

            People

            Assignee:
            davosmith Davo Smith
            Reporter:
            davosmith Davo Smith
            Peer reviewer:
            Frédéric Massart
            Integrator:
            Dan Poltawski
            Tester:
            Ankit Agarwal
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jan/13