Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.6, 2.3.3, 2.4
    • Fix Version/s: 2.2.7, 2.3.4
    • Component/s: Language, Survey
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Navigate to Site Administration > Development > Purge all caches and Purge all caches
      2. Add or navigate to a survey activity
      3. view.php of the survey, with no attempt made, should present the string 'All questions are required and must be answered.' above the# # survey questions. Note the period at the end of the string.
      Show
      Navigate to Site Administration > Development > Purge all caches and Purge all caches Add or navigate to a survey activity view.php of the survey, with no attempt made, should present the string 'All questions are required and must be answered.' above the# # survey questions. Note the period at the end of the string.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE

      Description

      String allquestionrequireanswer, 'All questions are required and must be answered', is a complete sentence, and should have a period at the end.

      Test Instructions

      1. Apply patch
      2. Navigate to Site Administration > Development > Purge all caches and Purge all caches
      3. Add or navigate to a survey activity
      4. view.php of the survey, with no attempt made, should present the string 'All questions are required and must be answered.' above the survey questions. Note the period at the end of the string.

        Gliffy Diagrams

        1. patch-MDL-36540.txt
          0.7 kB
          Amy Groshek
        2. patch-MDL-36540-M23.txt
          0.7 kB
          Amy Groshek
        3. patch-MDL-36540-M24.txt
          0.7 kB
          Amy Groshek

          Activity

          Hide
          Amy Groshek added a comment -

          Attaching patch for 2.3

          Show
          Amy Groshek added a comment - Attaching patch for 2.3
          Hide
          Helen Foster added a comment -

          Amy, thanks for your typo fix patches. We now have an en_fix lang pack for making typo fixes and en string improvements, but since you have created patches and written testing instructions, I am submitting this issue for integration review.

          Show
          Helen Foster added a comment - Amy, thanks for your typo fix patches. We now have an en_fix lang pack for making typo fixes and en string improvements, but since you have created patches and written testing instructions, I am submitting this issue for integration review.
          Hide
          Amy Groshek added a comment -

          Thanks Helen. I searched around but didn't find any documentation on how to submit a fix. Do we need docs for that?

          Show
          Amy Groshek added a comment - Thanks Helen. I searched around but didn't find any documentation on how to submit a fix. Do we need docs for that?
          Hide
          Dan Poltawski added a comment -

          Thanks Amy, i've integrated this now (22, 23 and master).

          Yes, I think we do need some better documentation on this. Usually we would only accept a git branch, Tim Hunt wrote a blog post about it here:
          http://tjhunt.blogspot.com.au/2012/03/fixing-bug-in-moodle-core-mechanics.html

          We should probably turn that into a docs page.

          Show
          Dan Poltawski added a comment - Thanks Amy, i've integrated this now (22, 23 and master). Yes, I think we do need some better documentation on this. Usually we would only accept a git branch, Tim Hunt wrote a blog post about it here: http://tjhunt.blogspot.com.au/2012/03/fixing-bug-in-moodle-core-mechanics.html We should probably turn that into a docs page.
          Hide
          Rossiani Wijaya added a comment -

          Thanks for fixing this Amy.

          It displays the string properly.

          Tested for 2.2, 2.3 and master

          Test passed.

          Show
          Rossiani Wijaya added a comment - Thanks for fixing this Amy. It displays the string properly. Tested for 2.2, 2.3 and master Test passed.
          Hide
          Helen Foster added a comment -

          Amy, regarding documentation on how to suggest improvements to English language strings, I've added a paragraph to http://docs.moodle.org/en/AMOS with a pointer in http://docs.moodle.org/en/Translation_FAQ (since it's usually translators who notice language pack typos first!)

          If anyone can suggest anywhere else where how to suggest improvements to English language strings should be mentioned, such as somewhere in the dev docs, please shout!

          Show
          Helen Foster added a comment - Amy, regarding documentation on how to suggest improvements to English language strings, I've added a paragraph to http://docs.moodle.org/en/AMOS with a pointer in http://docs.moodle.org/en/Translation_FAQ (since it's usually translators who notice language pack typos first!) If anyone can suggest anywhere else where how to suggest improvements to English language strings should be mentioned, such as somewhere in the dev docs, please shout!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many, many thanks for your effort!

          Millions of people will enjoy the results of your work, yay!

          Closing as fixed. Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many, many thanks for your effort! Millions of people will enjoy the results of your work, yay! Closing as fixed. Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: