Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36544

Remove special border-radius on course/site description block, standard theme

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.6, 2.3.3, 2.4
    • Fix Version/s: 2.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Test Instructions

      1. Navigate to Site Administration > Development > Purge all caches and Purge all caches
      2. Turn editing on
      3. Add the Site/course description block to front page or course
      4. Edit the block and add a little content to it (if you're on the front page this will send you to edit the front page description in the front page settings)
      5. Turn editing off
      6. Site/course description block should have the same border-radius as the rest of the side blocks
      Show
      Test Instructions Navigate to Site Administration > Development > Purge all caches and Purge all caches Turn editing on Add the Site/course description block to front page or course Edit the block and add a little content to it (if you're on the front page this will send you to edit the front page description in the front page settings) Turn editing off Site/course description block should have the same border-radius as the rest of the side blocks
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
      git@github.com:amygroshek/moodle.git
    • Pull Master Branch:
      wip-MDL-36544-m24

      Description

      The course/site description block inhabits the side block areas just like other blocks, but it is given a 10px border-radius in the standard theme (other blocks have no border-radius). On sites where this block is used I am often asked to override the 10px border-radius to make this block look like the others. Generally speaking, a site will look more professional if border-radius is consistent across all elements of a given type (in this case, blocks).

      I realize that this block is special, and the developers want to accentuate it, but it seems like we would be able to leave it to theme developers to decide how they want to accentuate it, and otherwise leave border-radius the same as other blocks. (There is another aspect of this block's appearance that makes it special: this block has no header. So it still looks distinct without the special border-radius.)

        Gliffy Diagrams

          Activity

          Hide
          lazydaisy Mary Evans added a comment - - edited

          It looks fine, so I have set this for Integration Review, but it will also need to be Cherry Picked into Master.

          Show
          lazydaisy Mary Evans added a comment - - edited It looks fine, so I have set this for Integration Review, but it will also need to be Cherry Picked into Master.
          Hide
          agroshek Amy Groshek added a comment -

          Thanks Mary. Cherry-pick from 1 repo to another is beyond me, but I have created a new branch with the change for master.

          Show
          agroshek Amy Groshek added a comment - Thanks Mary. Cherry-pick from 1 repo to another is beyond me, but I have created a new branch with the change for master.
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks Mary/Amy.

          I've integrated this to 2.4 only as its technically an improvement and also its not nice to change the appearance mid way through the stable branch. (though very minor)

          Show
          poltawski Dan Poltawski added a comment - Thanks Mary/Amy. I've integrated this to 2.4 only as its technically an improvement and also its not nice to change the appearance mid way through the stable branch. (though very minor)
          Hide
          agroshek Amy Groshek added a comment -

          Super! Thank you Mary and Dan!

          Show
          agroshek Amy Groshek added a comment - Super! Thank you Mary and Dan!
          Hide
          skodak Petr Skoda added a comment -

          Confirming, the block radius is gone both in course and on the frontpage. Thanks.

          Show
          skodak Petr Skoda added a comment - Confirming, the block radius is gone both in course and on the frontpage. Thanks.
          Hide
          poltawski Dan Poltawski added a comment -

          Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

          ciao
          Dan

          Show
          poltawski Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/12