Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36547

Module not added to section for unit test generation

    Details

      Description

      phpunit_module_generator::precreate_course_module() takes an options array. One of the options is a section. The course_modules record needs a section record ID while add_mod_to_section() takes a section number (EG: 0,1,2,3,etc). Basically the activity is not added to the proper section's sequence.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              skodak Petr Skoda added a comment -

              Thanks a lot for the report. It was already kind of fixed in master, I decided to improve the coding style there a bit anyway. There is a new unit test for this now.

              Show
              skodak Petr Skoda added a comment - Thanks a lot for the report. It was already kind of fixed in master, I decided to improve the coding style there a bit anyway. There is a new unit test for this now.
              Hide
              bushido Mark Nielsen added a comment -

              Thanks!

              Show
              bushido Mark Nielsen added a comment - Thanks!
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated, thanks

              Show
              poltawski Dan Poltawski added a comment - Integrated, thanks
              Hide
              poltawski Dan Poltawski added a comment -

              phpunit gold

              Show
              poltawski Dan Poltawski added a comment - phpunit gold
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment - - edited

              23_STABLE phpunit test breaking with this applied!

              Link: http://integration.moodle.org:8080/job/07.%20Run%20phpunit%20UnitTests%20(23_STABLE)/6/

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - - edited 23_STABLE phpunit test breaking with this applied! Link: http://integration.moodle.org:8080/job/07.%20Run%20phpunit%20UnitTests%20(23_STABLE)/6/
              Hide
              skodak Petr Skoda added a comment -

              weird, I thought I tested this

              Show
              skodak Petr Skoda added a comment - weird, I thought I tested this
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment - - edited

              Created MDL-36753 to fix that problem... thanks, Petr!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - - edited Created MDL-36753 to fix that problem... thanks, Petr!
              Hide
              poltawski Dan Poltawski added a comment -

              Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

              ciao
              Dan

              Show
              poltawski Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/Jan/13