Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Make sure the following admin table has id and containns the following class: 'admintable generaltable'
      Also make sure there's is no inline style for the table.

      1. go to Site admin > plugins > blocks > Manage blocks
      2. go to Site admin > plugins > filters > manage filters
      3. go to Site admin > plugins > local plugins > manage local plugins
      4. go to Site admin > plugins > question types > manage question types
      5. go to Site admin > plugins > repositories > manage repositories
      6. go to Site admin > appearance > HTML settings
      7. go to Site admin > plugins > enrolments > manage enrol plugins
      8. go to Site admin > plugins > authentication > manage authentication
      9. go to Site admin > plugins > text editors > manage editors
      10. go to Site admin > plugins > licences > manage licences
      11. go to Site admin > plugins > web services > external services
      12. go to Site admin > plugins > web services > overview
      13. go to Site admin > plugins > web services > manage protocols
      14. go to Site admin > plugins > web services > manage tokens
      15. go to Site admin > appearance > manage tags
      Show
      Make sure the following admin table has id and containns the following class: 'admintable generaltable' Also make sure there's is no inline style for the table. go to Site admin > plugins > blocks > Manage blocks go to Site admin > plugins > filters > manage filters go to Site admin > plugins > local plugins > manage local plugins go to Site admin > plugins > question types > manage question types go to Site admin > plugins > repositories > manage repositories go to Site admin > appearance > HTML settings go to Site admin > plugins > enrolments > manage enrol plugins go to Site admin > plugins > authentication > manage authentication go to Site admin > plugins > text editors > manage editors go to Site admin > plugins > licences > manage licences go to Site admin > plugins > web services > external services go to Site admin > plugins > web services > overview go to Site admin > plugins > web services > manage protocols go to Site admin > plugins > web services > manage tokens go to Site admin > appearance > manage tags
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      46028

      Description

      Add consistency for admin setting table to have ID and class name.

        Issue Links

          Activity

          Hide
          Rossiani Wijaya added a comment -

          Note for integrators:

          Please integrate MDL-36554 first before this issue.

          Thanks

          Show
          Rossiani Wijaya added a comment - Note for integrators: Please integrate MDL-36554 first before this issue. Thanks
          Hide
          Ankit Agarwal added a comment -

          Hi Rosie,
          Sorry for the delay in the review.
          The patch looks good.
          Two minor things:-
          1 - There is some commented out code, which you might wanna remove
          2 - frontpagefiltersettings table is missing the class generaltable.

          Feel free to submit for integration after fixing those.
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Rosie, Sorry for the delay in the review. The patch looks good. Two minor things:- 1 - There is some commented out code, which you might wanna remove 2 - frontpagefiltersettings table is missing the class generaltable. Feel free to submit for integration after fixing those. Thanks
          Hide
          Rossiani Wijaya added a comment -

          Thanks Ankit for reviewing.

          Patch updated.

          Submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Thanks Ankit for reviewing. Patch updated. Submitting for integration review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (master only), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks!
          Hide
          Andrew Davis added a comment -

          "go to Site admin > appearance > HTML settings"

          This table has border=1 in its table tag. Is that bad?

          Show
          Andrew Davis added a comment - "go to Site admin > appearance > HTML settings" This table has border=1 in its table tag. Is that bad?
          Hide
          Andrew Davis added a comment -

          Apart from that one table the rest are all fine.

          Show
          Andrew Davis added a comment - Apart from that one table the rest are all fine.
          Hide
          Rossiani Wijaya added a comment - - edited

          Hi Andrew,

          Thanks for catching that.

          It is unnecessary to have the border attribute there since the generaltable has set styling for border.

          Updated patch and will notify integrators team.

          Show
          Rossiani Wijaya added a comment - - edited Hi Andrew, Thanks for catching that. It is unnecessary to have the border attribute there since the generaltable has set styling for border. Updated patch and will notify integrators team.
          Hide
          Dan Poltawski added a comment -

          Pulled that in, thanks Rosie

          Show
          Dan Poltawski added a comment - Pulled that in, thanks Rosie
          Hide
          Andrew Davis added a comment -

          Looks good. Passing.

          Show
          Andrew Davis added a comment - Looks good. Passing.
          Hide
          Dan Poltawski added a comment -

          Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

          Show
          Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: