Details

    • Testing Instructions:
      Hide
      1. Create a new External Tool in a course
      2. When creating the External Tool, be sure to fill in values for the following fields (Must click on Show Advanced to see some):
        • Secure Launch URL
        • Icon URL
        • Secure Icon URL
      3. Backup and restore this External Tool instance.
      4. In the restored External Tool instance, confirm that the three fields maintain their values.
      Show
      Create a new External Tool in a course When creating the External Tool, be sure to fill in values for the following fields (Must click on Show Advanced to see some): Secure Launch URL Icon URL Secure Icon URL Backup and restore this External Tool instance. In the restored External Tool instance, confirm that the three fields maintain their values.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36579_modLtiBackupFields
    • Rank:
      46061

      Description

      Adding the following fields to backup:

      • securetoolurl
      • debuglaunch
      • icon
      • secureicon

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          This makes sense, thanks Mark. I'm submitting for integration.

          Should this be back-ported?

          It'd be great if you are able to write more detailed testing instructions for this.

          Show
          Dan Poltawski added a comment - This makes sense, thanks Mark. I'm submitting for integration. Should this be back-ported? It'd be great if you are able to write more detailed testing instructions for this.
          Hide
          Mark Nielsen added a comment -

          Updated testing instructions. Currently the UI for debuglaunch is commented out, so no testing instructions for that field.

          Show
          Mark Nielsen added a comment - Updated testing instructions. Currently the UI for debuglaunch is commented out, so no testing instructions for that field.
          Hide
          Mark Nielsen added a comment -

          Should this be back-ported?

          It should be safe to backport and might help a lot of folks out.

          Show
          Mark Nielsen added a comment - Should this be back-ported? It should be safe to backport and might help a lot of folks out.
          Hide
          Sam Hemelryk added a comment -

          Thanks Mark, this has been integrated now.

          Given it appears safe to backport this issue it has also been backported.

          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Mark, this has been integrated now. Given it appears safe to backport this issue it has also been backported. Many thanks Sam
          Hide
          David Monllaó added a comment -

          It passes. The three fields values are restored

          Show
          David Monllaó added a comment - It passes. The three fields values are restored
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: