Moodle
  1. Moodle
  2. MDL-36591

Images are not showing in submission mode in online text submissions

    Details

    • Testing Instructions:
      Hide
      1. Create an assignment with "Online text" set to Yes
      2. Login as a student and create a submission with a single image and no text.
      3. The image will be viewable on the summary page of the assignment and not display a broken image icon.
      Show
      Create an assignment with "Online text" set to Yes Login as a student and create a submission with a single image and no text. The image will be viewable on the summary page of the assignment and not display a broken image icon.
    • Workaround:
      Hide

      Click the expand icon above the summary.

      Show
      Click the expand icon above the summary.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36591-master
    • Rank:
      46076

      Description

      1. Login to a test course.
      2. Navigate to a test 2.3 assignment set to online text submission.
      3. Add text with an uploaded image.
      4. Click Save changes.
      5. Image is not showing in a submission screen.

      Will attach patch shortly.

        Activity

        Hide
        Kirill Astashov added a comment -

        Attaching patch.

        Show
        Kirill Astashov added a comment - Attaching patch.
        Hide
        Damyon Wiese added a comment -

        Hi Kirill,

        Thanks for reporting this and providing a patch - I have marked this issue for peer review.

        Regards, Damyon

        Show
        Damyon Wiese added a comment - Hi Kirill, Thanks for reporting this and providing a patch - I have marked this issue for peer review. Regards, Damyon
        Hide
        Damyon Wiese added a comment -

        Thanks Kirill,

        I made some changes to your patch to reduce the line length and added testing instructions as I think this patch would be a good one to get integrated soon.

        Show
        Damyon Wiese added a comment - Thanks Kirill, I made some changes to your patch to reduce the line length and added testing instructions as I think this patch would be a good one to get integrated soon.
        Hide
        Dan Poltawski added a comment -

        Integrated to master, 24 and 23.

        Thanks guys.

        Show
        Dan Poltawski added a comment - Integrated to master, 24 and 23. Thanks guys.
        Hide
        Frédéric Massart added a comment -

        Test passed on 2.3 and 2.4. Thanks!

        Note, the image is also displayed on the grading page, which affects the look and feel of the grading table. Just saying, I don't know if it's wanted.

        Show
        Frédéric Massart added a comment - Test passed on 2.3 and 2.4. Thanks! Note, the image is also displayed on the grading page, which affects the look and feel of the grading table. Just saying, I don't know if it's wanted.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: