Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36626 Meta: Ical Bug fixes and improvments
  3. MDL-36592

Ical import should consider all line endings while importing

          Details

          • Type: Sub-task
          • Status: Closed
          • Priority: Blocker
          • Resolution: Fixed
          • Affects Version/s: 2.4
          • Fix Version/s: 2.4
          • Component/s: Calendar
          • Labels:
          • Testing Instructions:
            Hide
            1. Goto sitepages>calander>manage subscription
            2. Remove all subscriptions you have there
            3. add this http://ical.mac.com/ical/US32Holidays.ics as subscription
            4. Make sure all events are created properly
            5. Remove the subscription
            6. Make sure all events corresponding to the url are deleted.
            7. repeat step 3 -6 for the two attached file.
            Show
            Goto sitepages>calander>manage subscription Remove all subscriptions you have there add this http://ical.mac.com/ical/US32Holidays.ics as subscription Make sure all events are created properly Remove the subscription Make sure all events corresponding to the url are deleted. repeat step 3 -6 for the two attached file.
          • Affected Branches:
            MOODLE_24_STABLE
          • Fixed Branches:
            MOODLE_24_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-36592-master
          • Pull Master Diff URL:

            Description

            copying my comment from linked issue:-
            While working on this I noticed some files dont work, while others did with the correct format. after spending quite some time debugging the problem I found was the "newline" character used in those files i.e "\n" instead of "\r\n". Which was breaking everything as $ical::unserialize couldnt find the event details as it does an explode on "\r\n" only. I will create a blocker for that .
            try using this file http://ical.mac.com/ical/US32Holidays.ics
            Thanks

              Gliffy Diagrams

                Attachments

                  Issue Links

                  blocks

                  Functional Test - A test of a single Moodle feature MDLQA-5207 CLONE - A user can import a calendar via URL

                  • Passed
                  Testing discovered

                  New Feature - A new Moodle feature which has yet to be developed. MDL-16660 Calendar: IMPORT or Subscribe to iCal feed into Moodle calendar

                  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
                  • Closed
                  will help resolve

                  Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36525 Calendar import should follow redirects

                  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
                  • Closed

                    Activity

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        2 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          3/Dec/12