Moodle
  1. Moodle
  2. MDL-36601

Log report doesn't remember "All days" setting

    Details

    • Testing Instructions:
      Hide
      • Navigate to Home -> Site Pages -> Reports -> Logs
      • Note the current value for the day (Today, ....)
      • Search
        • Confirm that the form values still show the same day value
      • Change the day selector to 'All days'
      • Search
        • Confirm that the day selector retains the 'All days' value
      Show
      Navigate to Home -> Site Pages -> Reports -> Logs Note the current value for the day (Today, ....) Search Confirm that the form values still show the same day value Change the day selector to 'All days' Search Confirm that the day selector retains the 'All days' value
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36601-master
    • Rank:
      46093

      Description

      When generating an activity report, if you select "All days", after submitting the value has defaulted back to today.

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          I'll provide patches for 2.2 and 2.3 after peer review.

          Show
          Andrew Nicols added a comment - I'll provide patches for 2.2 and 2.3 after peer review.
          Hide
          Ankit Agarwal added a comment -

          Hi Andrew,
          Patch looks good. Please feel free to submit for integration after backporting.

          [y] Syntax
          [y] Output
          [y] Whitespace
          [y] Language
          [-] Databases
          [y] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Thanks

          Show
          Ankit Agarwal added a comment - Hi Andrew, Patch looks good. Please feel free to submit for integration after backporting. [y] Syntax [y] Output [y] Whitespace [y] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check Thanks
          Hide
          Sam Hemelryk added a comment -

          Thanks Andrew, changes look good and this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Andrew, changes look good and this has been integrated now.
          Hide
          Rajesh Taneja added a comment -

          Thanks Andrew,

          Works Grt.

          Show
          Rajesh Taneja added a comment - Thanks Andrew, Works Grt.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: