Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36607

Drag and drop blocks does not work with subpage values and custom regions

    Details

    • Testing Instructions:
      Hide

      Ensure that there is no regression on block drag and drop within a course.

      1. Go into a course
      2. Turn on editing
      3. Try re-arranging blocks within the same region and across different regions (EG: drag a block from the left side to the right side)
      Show
      Ensure that there is no regression on block drag and drop within a course. Go into a course Turn on editing Try re-arranging blocks within the same region and across different regions (EG: drag a block from the left side to the right side)
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE

      Description

      This primarily helps to bring in support for Flexpage with drag and drop block support. But, there is nothing unique happening here. For example: I believe this would allow drag and drop blocks to work on the My Moodle page with the custom center block region of "content" (may need some extra dom around the content block region).

      So, changes include:

      • Passing subpage value to lib/ajax/blocks.php
      • Don't assume that every region starts with "side-"

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for that, Mark.

            Feel free to add some testing instructions and push this for peer review.

            Show
            salvetore Michael de Raadt added a comment - Thanks for that, Mark. Feel free to add some testing instructions and push this for peer review.
            Hide
            kabalin Ruslan Kabalin added a comment -

            Looks good to me.

            Show
            kabalin Ruslan Kabalin added a comment - Looks good to me.
            Hide
            kabalin Ruslan Kabalin added a comment - - edited

            [x] Syntax
            [x] Output
            [x] Whitespace
            [x] Testing
            [x] Security
            [x] Documentation
            [x] Git
            [x] Sanity check

            All good! Please submit for integration whenever convenient.

            Show
            kabalin Ruslan Kabalin added a comment - - edited [x] Syntax [x] Output [x] Whitespace [x] Testing [x] Security [x] Documentation [x] Git [x] Sanity check All good! Please submit for integration whenever convenient.
            Hide
            bushido Mark Nielsen added a comment -

            Well, I have just gone in a circle with the JIRA workflow - how might I get this to integration?

            Show
            bushido Mark Nielsen added a comment - Well, I have just gone in a circle with the JIRA workflow - how might I get this to integration?
            Hide
            timhunt Tim Hunt added a comment -

            Submitting for integration on behalf of Mark, who does not have permission.

            Show
            timhunt Tim Hunt added a comment - Submitting for integration on behalf of Mark, who does not have permission.
            Hide
            kabalin Ruslan Kabalin added a comment -

            Sorry Mark, have not realised you do not have permission, I had to submit it myself.

            Show
            kabalin Ruslan Kabalin added a comment - Sorry Mark, have not realised you do not have permission, I had to submit it myself.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Mark, this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Mark, this has been integrated now.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Works Grt., Can D-n-D blocks on same and between different regions.
            Thanks for fixing this Mark.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Works Grt., Can D-n-D blocks on same and between different regions. Thanks for fixing this Mark.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13