Moodle

Sky High theme missing background image in Admin report page

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.3.4, 2.4.1
  • Component/s: Themes
  • Labels:

Description

The tri-colored background is missing from Admin report pages because of incorrect CSS in ../theme/sky_high/style/admin.css

Issue Links

discovered while testing

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36576 Course categories view /course/index.php, apply .generaltable class instead of .generalbox

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Poltawski added a comment -

Hi Mary, can you confirm which branches this affects? Does it need backporting?

Show
Dan Poltawski added a comment - Hi Mary, can you confirm which branches this affects? Does it need backporting?
Hide
Permalink
Mary Evans added a comment - - edited

@Dan
Sorry I was testing this late last night and forgot to change the FIX version. It only affects 2.3 so changes need to go into 2.3.x and master

Show
Mary Evans added a comment - - edited @Dan Sorry I was testing this late last night and forgot to change the FIX version. It only affects 2.3 so changes need to go into 2.3.x and master
Hide
Permalink
Mary Evans added a comment -

@Dan
Just added Pull 2.3 Branch and Diff

Show
Mary Evans added a comment - @Dan Just added Pull 2.3 Branch and Diff
Hide
Permalink
Mary Evans added a comment -

I have just re-based this, but realise now this needs to go into MOODLE_24_STABLE as well. If I have time I'll add a M24 branch.

Show
Mary Evans added a comment - I have just re-based this, but realise now this needs to go into MOODLE_24_STABLE as well. If I have time I'll add a M24 branch.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Mary, this has been integrated now

Show
Sam Hemelryk added a comment - Thanks Mary, this has been integrated now
Hide
Permalink
Rajesh Taneja added a comment -

Thanks for fixing this Mary.
Background image is now visible on admin pages and report page.

Show
Rajesh Taneja added a comment - Thanks for fixing this Mary. Background image is now visible on admin pages and report page.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: