Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36608

Sky High theme missing background image in Admin report page

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.3
          • Fix Version/s: 2.3.4, 2.4.1
          • Component/s: Themes
          • Labels:
          • Testing Instructions:
            Hide
            1. Select Sky High theme from theme selector NOT by URL
            2. NEXT go to Theme settings page, or any Admin page and TEST to see that the tri-color background image is visible.
            3. TEST for same background image in ANY report page too.
            Show
            Select Sky High theme from theme selector NOT by URL NEXT go to Theme settings page, or any Admin page and TEST to see that the tri-color background image is visible. TEST for same background image in ANY report page too.
          • Affected Branches:
            MOODLE_23_STABLE
          • Fixed Branches:
            MOODLE_23_STABLE, MOODLE_24_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-36608_master
          • Pull Master Diff URL:

            Description

            The tri-colored background is missing from Admin report pages because of incorrect CSS in ../theme/sky_high/style/admin.css

              Gliffy Diagrams

                Attachments

                  Issue Links

                  Testing discovered

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36576 Course categories view /course/index.php, apply .generaltable class instead of .generalbox

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    Hi Mary, can you confirm which branches this affects? Does it need backporting?

                    Show
                    poltawski Dan Poltawski added a comment - Hi Mary, can you confirm which branches this affects? Does it need backporting?
                    Hide
                    Permalink
                    lazydaisy Mary Evans added a comment - - edited

                    @Dan
                    Sorry I was testing this late last night and forgot to change the FIX version. It only affects 2.3 so changes need to go into 2.3.x and master

                    Show
                    lazydaisy Mary Evans added a comment - - edited @Dan Sorry I was testing this late last night and forgot to change the FIX version. It only affects 2.3 so changes need to go into 2.3.x and master
                    Hide
                    Permalink
                    lazydaisy Mary Evans added a comment -

                    @Dan
                    Just added Pull 2.3 Branch and Diff

                    Show
                    lazydaisy Mary Evans added a comment - @Dan Just added Pull 2.3 Branch and Diff
                    Hide
                    Permalink
                    lazydaisy Mary Evans added a comment -

                    I have just re-based this, but realise now this needs to go into MOODLE_24_STABLE as well. If I have time I'll add a M24 branch.

                    Show
                    lazydaisy Mary Evans added a comment - I have just re-based this, but realise now this needs to go into MOODLE_24_STABLE as well. If I have time I'll add a M24 branch.
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Thanks Mary, this has been integrated now

                    Show
                    samhemelryk Sam Hemelryk added a comment - Thanks Mary, this has been integrated now
                    Hide
                    Permalink
                    rajeshtaneja Rajesh Taneja added a comment -

                    Thanks for fixing this Mary.
                    Background image is now visible on admin pages and report page.

                    Show
                    rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this Mary. Background image is now visible on admin pages and report page.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

                    Closing, ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        0 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          14/Jan/13