Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Calendar
    • Labels:
    • Rank:
      46107

      Description

      Rename "global event" option to "site events" in ical imports as it will be consistent with rest of the calendar

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          Sam,
          Do you think it is a good idea to do this renaming?
          Thanks

          Show
          Ankit Agarwal added a comment - Sam, Do you think it is a good idea to do this renaming? Thanks
          Hide
          Sam Hemelryk added a comment -

          Yip, gets a +1 from me for sure.

          Show
          Sam Hemelryk added a comment - Yip, gets a +1 from me for sure.
          Hide
          Ankit Agarwal added a comment - - edited

          Thanks Sam for the the feedback
          I have left other usage of "global events" keyword as in nav block, it makes sense in there to me. However the type must be consistent all over the place.
          Requesting a review.
          Thanks

          Show
          Ankit Agarwal added a comment - - edited Thanks Sam for the the feedback I have left other usage of "global events" keyword as in nav block, it makes sense in there to me. However the type must be consistent all over the place. Requesting a review. Thanks
          Hide
          Rossiani Wijaya added a comment -

          This looks great Ankit.

          [y] Syntax
          [y] Output
          [y] Whitespace
          [-] Language
          [-] Databases
          [-] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Show
          Rossiani Wijaya added a comment - This looks great Ankit. [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [-] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
          Hide
          Ankit Agarwal added a comment -

          Thanks for the review Rosie. Sending for integration.

          Show
          Ankit Agarwal added a comment - Thanks for the review Rosie. Sending for integration.
          Hide
          Sam Hemelryk added a comment -

          Thanks Ankit, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Ankit, this has been integrated now.
          Hide
          Sam Hemelryk added a comment -

          Marking test passed as the QA issue will see it tested.

          Show
          Sam Hemelryk added a comment - Marking test passed as the QA issue will see it tested.
          Hide
          Dan Poltawski added a comment -

          Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

          ciao
          Dan

          Show
          Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: