Moodle
  1. Moodle
  2. MDL-36616

Flickr Public repository "Link to the file directly" option fails

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.4
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Repositories
    • Labels:
      None
    • Rank:
      46108

      Description

      Attempting to use the "Link to the file directly" option in the Flickr public repository generates this fatal error:

      Call to undefined method repository_flickr_public::build_photo_id()

      Which causes an invalid JSON response, which prevents the user from being able to embed the image.

      I am assuming this is supposed to be a call to repository_flickr_public::build_photo_url(). My patch changes this and the feature seems to work as intended now.

        Activity

        Hide
        Frédéric Massart added a comment -

        Thanks for your patch Ashley. I've added some testing instructions and am pushing this straight to integration as I'm acting as a peer reviewer here.

        Cheers,
        Fred

        Show
        Frédéric Massart added a comment - Thanks for your patch Ashley. I've added some testing instructions and am pushing this straight to integration as I'm acting as a peer reviewer here. Cheers, Fred
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Integrated to 24, 23 and master.

        Thanks Ashley.

        Show
        Dan Poltawski added a comment - Integrated to 24, 23 and master. Thanks Ashley.
        Hide
        Jason Fowler added a comment -

        Great work Fred, now all the pictures of monkeys playing the drums show up in my moodle correctly!

        Show
        Jason Fowler added a comment - Great work Fred, now all the pictures of monkeys playing the drums show up in my moodle correctly!
        Hide
        Dan Poltawski added a comment -

        Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

        Show
        Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: