Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36626 Meta: Ical Bug fixes and improvments
  3. MDL-36621

Display the source of event in ical imported events and implement MUC for calendar subscriptions

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide

      TEST 1

      1. login as admin
      2. Purge caches
      3. create a few calendar events
      4. goto calendar>manage subscriptions and add a subscription using url

        https://www.google.com/calendar/ical/en.australian%23holiday%40group.v.calendar.google.com/public/basic.ics
        

      5. Create another subscription from a file, if you dont have a file, just logon to moodle.org and export your calendar as file and use that file.
      6. visit the calendar and make sure you see the imported events from above feed as normal events
      7. Enable the setting calendar_showicalsource from admin settings
      8. click on any date and go to day view
      9. make sure you see ical events with source listed and linked(only for url imported events), other manually created events should appear normally
      10. Change language to rtl. make sure the source info is now right aligned.
      11. Disable the setting calendar_showicalsource from admin settings
      12. Make sure the ical source info is not displayed anymore

      TEST 2

      1. add calendar blocks on any page
      2. see that you can see the calendar event popups without anyissue for both mouseover and onfoucus
      3. beside the event name the subciprion info should not be displayed for ical events.
      4. Enable the setting calendar_showicalsource from admin settings
      5. beside the event name the subciprion info should be displayed for ical events.

      TEST 3

      1. Delete both subscriptions and make sure there is no error.

      TEST 4

      1. A regression testing session is need for the ical feature as almost every function of the ical import is effected by this change.

      TEST 5

      1. Enable performance info and all other debuging info if you dont have it enabled http://docs.moodle.org/23/en/Debugging
      2. Add a ical url subscription
      3. update the subscription and in the performance info make sure you see calendar_subscriptions in the cache section on the landing page after updating the subscription
      4. In the same section make sure you see a lot of hits and very few misses, the number of hits should be somewhere around the number of imported events.
      5. Note the number of DB reads
      6. Goto a moodle instance without this patch and add the same exact ical url subscription and update
      7. note the number of DB reads and make sure it is way more than what is noted in step 5 (around the number of imported events)
      Show
      TEST 1 login as admin Purge caches create a few calendar events goto calendar>manage subscriptions and add a subscription using url https://www.google.com/calendar/ical/en.australian%23holiday%40group.v.calendar.google.com/public/basic.ics Create another subscription from a file, if you dont have a file, just logon to moodle.org and export your calendar as file and use that file. visit the calendar and make sure you see the imported events from above feed as normal events Enable the setting calendar_showicalsource from admin settings click on any date and go to day view make sure you see ical events with source listed and linked(only for url imported events), other manually created events should appear normally Change language to rtl. make sure the source info is now right aligned. Disable the setting calendar_showicalsource from admin settings Make sure the ical source info is not displayed anymore TEST 2 add calendar blocks on any page see that you can see the calendar event popups without anyissue for both mouseover and onfoucus beside the event name the subciprion info should not be displayed for ical events. Enable the setting calendar_showicalsource from admin settings beside the event name the subciprion info should be displayed for ical events. TEST 3 Delete both subscriptions and make sure there is no error. TEST 4 A regression testing session is need for the ical feature as almost every function of the ical import is effected by this change. TEST 5 Enable performance info and all other debuging info if you dont have it enabled http://docs.moodle.org/23/en/Debugging Add a ical url subscription update the subscription and in the performance info make sure you see calendar_subscriptions in the cache section on the landing page after updating the subscription In the same section make sure you see a lot of hits and very few misses, the number of hits should be somewhere around the number of imported events. Note the number of DB reads Goto a moodle instance without this patch and add the same exact ical url subscription and update note the number of DB reads and make sure it is way more than what is noted in step 5 (around the number of imported events)
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-36621-master

      Description

      A simple text displaying the name of subscription source should be present in the event description.

      I am marking this as mdlqa, it will be nice to get this sorted before 2.4 release, but its optional.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13