Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.3
    • Fix Version/s: 2.4
    • Component/s: Usability
    • Labels:
    • Testing Instructions:
      Hide

      Test pre-requisites

      • Have a few courses and categories

      Test steps

      1. Go to each of the following pages
        • Frontpage (with course list, and combo box)
        • Course/index.php
        • Course/category.php
        • Play with the settings coursesperpage and courseswithsummarieslimit to modify the previous pages.
      2. Make sure:
        • new icons are displayed
        • the fallback on PNG works
        • looks good on major browsers

      The course icon is missing, that's a known issue

      Show
      Test pre-requisites Have a few courses and categories Test steps Go to each of the following pages Frontpage (with course list, and combo box) Course/index.php Course/category.php Play with the settings coursesperpage and courseswithsummarieslimit to modify the previous pages. Make sure : new icons are displayed the fallback on PNG works looks good on major browsers The course icon is missing, that's a known issue
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36623-master-int
    • Rank:
      46116

      Description

      Redesign course access icons in svg and png formats

      1. course1.png
        20 kB
      2. course2.png
        44 kB
      3. course3.png
        17 kB
      4. course4.png
        26 kB
      5. Screen Shot 2012-11-15 at 11.52.39 AM.png
        44 kB

        Issue Links

          Activity

          Hide
          Barbara Ramiro added a comment -

          Fred, could you add few pixels around the icons especially the top. Thanks

          Show
          Barbara Ramiro added a comment - Fred, could you add few pixels around the icons especially the top. Thanks
          Hide
          Frédéric Massart added a comment -

          Back to development because the course icon needs more work.

          Show
          Frédéric Massart added a comment - Back to development because the course icon needs more work.
          Hide
          Frédéric Massart added a comment -

          (Removed the course icon from this patch because it needs for discussion. MDL-36765 was raised for that)

          Show
          Frédéric Massart added a comment - (Removed the course icon from this patch because it needs for discussion. MDL-36765 was raised for that)
          Hide
          Mark Nelson added a comment -

          Hi Fred, looks good.

          Few issues:

          1) Is it necessary to add an empty string after $courseicon = $OUTPUT->render($pix_icon)?
          2) You added an unnecessary white line in theme/base/style/course.css
          3) Some of the '{' characters have spaces after them, some don't.
          4) Sometimes you use px, others you use em.

          Show
          Mark Nelson added a comment - Hi Fred, looks good. Few issues: 1) Is it necessary to add an empty string after $courseicon = $OUTPUT->render($pix_icon)? 2) You added an unnecessary white line in theme/base/style/course.css 3) Some of the '{' characters have spaces after them, some don't. 4) Sometimes you use px, others you use em.
          Hide
          Frédéric Massart added a comment -

          1) Fixed, thanks!
          2) Fixed
          3) Well, there is no guide lines, so I admit that I haven't really added anything consistent over the CSS files.
          4) As much as I can I would use em as it's better, but some places require px as they're sort of a hack. Not proud of it, but px are used everywhere, just trying to use some nice em when I can.

          Pushing for integration. Thanks!

          Show
          Frédéric Massart added a comment - 1) Fixed, thanks! 2) Fixed 3) Well, there is no guide lines, so I admit that I haven't really added anything consistent over the CSS files. 4) As much as I can I would use em as it's better, but some places require px as they're sort of a hack. Not proud of it, but px are used everywhere, just trying to use some nice em when I can. Pushing for integration. Thanks!
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks guys.

          Show
          Dan Poltawski added a comment - Integrated, thanks guys.
          Hide
          Adrian Greeve added a comment -

          Tested on the major browsers.
          I played around with the settings and checked out the pages mentioned.
          Everything looks good. No problems discovered.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested on the major browsers. I played around with the settings and checked out the pages mentioned. Everything looks good. No problems discovered. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Y E S !

          Closing as fixed, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: