Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Usability
    • Labels:
      None
    • Testing Instructions:
      Hide

      Test pre-requisites

      • Add the Online Users block
      • Connect simultaneous with other accounts so that you can see something in the block
      • Use all the major browsers to test this issue

      Test steps

      1. Check for consistency in the block styles, CSS, icons, etc...
      2. Go to Home ► Course ► Reports ► Course participation
      3. Make a search so that you have results
      4. Hack user/message.html:46 (right before `if (!empty($error))` and set $error to something.
      5. Now select a bunch of users and "Send a message"
      6. You should see an icon next to the list of users, make sure it appears nicely
      7. Revert your hack and make sure it still look nice

      I didn't find a quick way to display this icon without hacking the code

      Show
      Test pre-requisites Add the Online Users block Connect simultaneous with other accounts so that you can see something in the block Use all the major browsers to test this issue Test steps Check for consistency in the block styles, CSS, icons, etc... Go to Home ► Course ► Reports ► Course participation Make a search so that you have results Hack user/message.html:46 (right before `if (!empty($error))` and set $error to something. Now select a bunch of users and "Send a message" You should see an icon next to the list of users, make sure it appears nicely Revert your hack and make sure it still look nice I didn't find a quick way to display this icon without hacking the code
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36630-master

      Description

      Online users block icon issues

        Gliffy Diagrams

          Activity

          Hide
          Frédéric Massart added a comment -

          The icon to send a message does not meet the new standards. See icon_block_online_users.png

          Show
          Frédéric Massart added a comment - The icon to send a message does not meet the new standards. See icon_block_online_users.png
          Hide
          Frédéric Massart added a comment -

          I can't find an easy way to display 'emailno' but here is a screenshot that should help to see it in context.

          Show
          Frédéric Massart added a comment - I can't find an easy way to display 'emailno' but here is a screenshot that should help to see it in context.
          Hide
          Frédéric Massart added a comment -

          Note: t/email does not seem to be used at all but as this icon is quite important by its name, we decided to create an icon for it.

          Show
          Frédéric Massart added a comment - Note: t/email does not seem to be used at all but as this icon is quite important by its name, we decided to create an icon for it.
          Hide
          Mark Nelson added a comment -

          Hi Fred,

          Looks good.

          However, for the line .user .userpicture

          { vertical-align: text-bottom;}

          you have a space after the bracket. No big deal.

          Show
          Mark Nelson added a comment - Hi Fred, Looks good. However, for the line .user .userpicture { vertical-align: text-bottom;} you have a space after the bracket. No big deal.
          Hide
          Frédéric Massart added a comment -

          Thanks, pushing for integration!

          Show
          Frédéric Massart added a comment - Thanks, pushing for integration!
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks.

          Show
          Dan Poltawski added a comment - Integrated, thanks.
          Hide
          Jason Fowler added a comment -

          Worked fine, once I realised I needed to swap back to the recipient user.

          Show
          Jason Fowler added a comment - Worked fine, once I realised I needed to swap back to the recipient user.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Y E S !

          Closing as fixed, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: