Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Usability
    • Labels:
      None
    • Rank:
      46124

      Description

      Messaging icon issues

      1. icon_messaging.png
        55 kB
      2. messageexchange.png
        20 kB
      3. messaging_unblock.png
        38 kB

        Activity

        Hide
        Frédéric Massart added a comment -

        After searching for users to send a message to, the action icons:

        • Add to contact
        • Block user
        • Show history

        Do not meet the new standards. See icon_messaging.png

        Show
        Frédéric Massart added a comment - After searching for users to send a message to, the action icons: Add to contact Block user Show history Do not meet the new standards. See icon_messaging.png
        Hide
        Frédéric Massart added a comment -

        Attaching screenshot to 'unblock' icon

        Show
        Frédéric Massart added a comment - Attaching screenshot to 'unblock' icon
        Hide
        Mark Nelson added a comment -

        Hi Fred, looks good.

        A few points:

        1. Testing instructions are a bit vague. This may encourage testers to be lazy, or miss an important page. How about creating testing instructions that cover all basis of the messaging system? Example, create two accounts, visit this page as one of the users, message the other user, as the other user view the message, reply, block the user and unblock etc etc. Something that will mean all icons are displayed and used.
        2. You use a TODO, without a '@'.
        3. Do we need that large chunk TODO on that page or can we put this in a tracker issue?
        4. "Delete those things?" is not really descriptive. Do you mean go through that specific file and delete references to that, or for all of Moodle?
        5. You have deprecated t/userblue and have written about it in theme/upgrade.txt which is good, but you also did the same to t/log and t/addgreen, so should mention those as well.
        Show
        Mark Nelson added a comment - Hi Fred, looks good. A few points: Testing instructions are a bit vague. This may encourage testers to be lazy, or miss an important page. How about creating testing instructions that cover all basis of the messaging system? Example, create two accounts, visit this page as one of the users, message the other user, as the other user view the message, reply, block the user and unblock etc etc. Something that will mean all icons are displayed and used. You use a TODO, without a '@'. Do we need that large chunk TODO on that page or can we put this in a tracker issue? "Delete those things?" is not really descriptive. Do you mean go through that specific file and delete references to that, or for all of Moodle? You have deprecated t/userblue and have written about it in theme/upgrade.txt which is good, but you also did the same to t/log and t/addgreen, so should mention those as well.
        Hide
        Frédéric Massart added a comment -

        Thanks Mark.

        I chose the exploratory testing on purpose. I am not expecting the tester to spend hours on this, but without my precise instructions they might end up on pages that I didn't think about, and I think this makes more sense in this case.

        I removed the entire unused block of code. As it was already not used, commenting it out didn't make much sense either.

        The only icon which is deprecated is userblue because I didn't investigate on the others ones which are (or might) be used in other places.

        Pushing for integration, cheers!

        Show
        Frédéric Massart added a comment - Thanks Mark. I chose the exploratory testing on purpose. I am not expecting the tester to spend hours on this, but without my precise instructions they might end up on pages that I didn't think about, and I think this makes more sense in this case. I removed the entire unused block of code. As it was already not used, commenting it out didn't make much sense either. The only icon which is deprecated is userblue because I didn't investigate on the others ones which are (or might) be used in other places. Pushing for integration, cheers!
        Hide
        Mark Nelson added a comment -

        Hi Fred, I did a grep on the others ones, they are not in use anywhere else.

        Show
        Mark Nelson added a comment - Hi Fred, I did a grep on the others ones, they are not in use anywhere else.
        Hide
        Frédéric Massart added a comment -

        Mark, addgreen is used in some other places (Marking guide). And the log icon is hard to track down, I prefer leaving them there for now.

        Show
        Frédéric Massart added a comment - Mark, addgreen is used in some other places (Marking guide). And the log icon is hard to track down, I prefer leaving them there for now.
        Hide
        Dan Poltawski added a comment -

        Integrated, thanks guys.

        Show
        Dan Poltawski added a comment - Integrated, thanks guys.
        Hide
        Dan Poltawski added a comment -

        ps. in differnet circumstances it would've been nice to switch new moodle_url("/message/index.php?id=$user->id"); to a proper params array eing passed..

        Show
        Dan Poltawski added a comment - ps. in differnet circumstances it would've been nice to switch new moodle_url("/message/index.php?id=$user->id"); to a proper params array eing passed..
        Hide
        Adrian Greeve added a comment -

        Tested on Chrome, IE9, Firefox, and Safari.
        All of the messaging icons look the same. Formatting looks fine.
        Test passed.

        Show
        Adrian Greeve added a comment - Tested on Chrome, IE9, Firefox, and Safari. All of the messaging icons look the same. Formatting looks fine. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Y E S !

        Closing as fixed, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: