Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36646

Several unit tests hard code numbers of contexts

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.3
    • Fix Version/s: 2.3.4
    • Component/s: Unit tests
    • Labels:
    • Testing Instructions:
      Hide

      1. Run the unit tests. Verify that they all pass.
      2. Install mod_oublog
      3. Run the unit tests. Verify that they all pass.

      Step 3 was failing before.

      Show
      1. Run the unit tests. Verify that they all pass. 2. Install mod_oublog 3. Run the unit tests. Verify that they all pass. Step 3 was failing before.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      At least one of the OU custom plugins creates a context during install, which then breaks these assumptions and tests. I have fixed them.

        Gliffy Diagrams

          Activity

          Hide
          timhunt Tim Hunt added a comment -

          I think this is it.

          Show
          timhunt Tim Hunt added a comment - I think this is it.
          Hide
          skodak Petr Skoda added a comment -

          // depends on number of default blocks
          does not seem correct any more because you added add-on activities on the frontpage

          the rest looks ok

          Show
          skodak Petr Skoda added a comment - // depends on number of default blocks does not seem correct any more because you added add-on activities on the frontpage the rest looks ok
          Hide
          timhunt Tim Hunt added a comment -

          Well, so the original comment was wrong. The number really depends on the number of front-page blocks and the number of front page activities. Now that I have allowed for the number of front-page modules in the code, the comment is more accurate than it was!

          Show
          timhunt Tim Hunt added a comment - Well, so the original comment was wrong. The number really depends on the number of front-page blocks and the number of front page activities. Now that I have allowed for the number of front-page modules in the code, the comment is more accurate than it was!
          Hide
          poltawski Dan Poltawski added a comment -

          Integrated, thanks Tim.

          Show
          poltawski Dan Poltawski added a comment - Integrated, thanks Tim.
          Hide
          skodak Petr Skoda added a comment -

          tests passed, thanks

          Show
          skodak Petr Skoda added a comment - tests passed, thanks
          Hide
          poltawski Dan Poltawski added a comment -

          Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

          ciao
          Dan

          Show
          poltawski Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

            People

            • Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Petr Skoda
              Integrator:
              Dan Poltawski
              Tester:
              Petr Skoda
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jan/13