Moodle

When restoring courses with a different course start date, do no modify question timecreated or timemodified

Details

  • Testing Instructions:
    Hide

    1. Create a course and note the start date you set.

    2. Create a question.

    3. Edit the question.

    4. Note the question created and last modified timestamps.

    5. Backup the course.

    6. Restore the course, changing the course start date.

    7. Verify that the restored question has the same start and modified date as the original question.

    Show
    1. Create a course and note the start date you set. 2. Create a question. 3. Edit the question. 4. Note the question created and last modified timestamps. 5. Backup the course. 6. Restore the course, changing the course start date. 7. Verify that the restored question has the same start and modified date as the original question.
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

My view (and the view of others at the OU) is that these fields are metadata, not course settings, so that they should not be modified just because the course start date has changed.

Before this is integrated, we need to canvas the opinions of others in the quiz forum, to make sure they are happy with this change.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Forum thread: https://moodle.org/mod/forum/discuss.php?d=215996

Show
Tim Hunt added a comment - Forum thread: https://moodle.org/mod/forum/discuss.php?d=215996
Hide
Permalink
Tim Hunt added a comment -

So far, in the forum, there have been no objections to my proposal; two people who agree with it; and one person who suggested something much more complex that is unlike anything else we have in backup. (And that does not count my vote, or that of my colleagues.)

That is good enough for me. I am submitting this for integration.

Show
Tim Hunt added a comment - So far, in the forum, there have been no objections to my proposal; two people who agree with it; and one person who suggested something much more complex that is unlike anything else we have in backup. (And that does not count my vote, or that of my colleagues.) That is good enough for me. I am submitting this for integration.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Tim, I agree that it is closer to meta data than real data. I've integrated this change now.

Show
Sam Hemelryk added a comment - Thanks Tim, I agree that it is closer to meta data than real data. I've integrated this change now.
Hide
Permalink
Michael de Raadt added a comment -

Test result: Success!

Tested in 2.2, 2.3 and master.

Show
Michael de Raadt added a comment - Test result: Success! Tested in 2.2, 2.3 and master.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: