Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36650

When restoring courses with a different course start date, do no modify question timecreated or timemodified

          Details

          • Testing Instructions:
            Hide

            1. Create a course and note the start date you set.

            2. Create a question.

            3. Edit the question.

            4. Note the question created and last modified timestamps.

            5. Backup the course.

            6. Restore the course, changing the course start date.

            7. Verify that the restored question has the same start and modified date as the original question.

            Show
            1. Create a course and note the start date you set. 2. Create a question. 3. Edit the question. 4. Note the question created and last modified timestamps. 5. Backup the course. 6. Restore the course, changing the course start date. 7. Verify that the restored question has the same start and modified date as the original question.
          • Affected Branches:
            MOODLE_23_STABLE
          • Fixed Branches:
            MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
          • Pull from Repository:
          • Pull Master Branch:
          • Pull Master Diff URL:

            Description

            My view (and the view of others at the OU) is that these fields are metadata, not course settings, so that they should not be modified just because the course start date has changed.

            Before this is integrated, we need to canvas the opinions of others in the quiz forum, to make sure they are happy with this change.

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Forum thread: https://moodle.org/mod/forum/discuss.php?d=215996

                  Show
                  timhunt Tim Hunt added a comment - Forum thread: https://moodle.org/mod/forum/discuss.php?d=215996
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  So far, in the forum, there have been no objections to my proposal; two people who agree with it; and one person who suggested something much more complex that is unlike anything else we have in backup. (And that does not count my vote, or that of my colleagues.)

                  That is good enough for me. I am submitting this for integration.

                  Show
                  timhunt Tim Hunt added a comment - So far, in the forum, there have been no objections to my proposal; two people who agree with it; and one person who suggested something much more complex that is unlike anything else we have in backup. (And that does not count my vote, or that of my colleagues.) That is good enough for me. I am submitting this for integration.
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks Tim, I agree that it is closer to meta data than real data. I've integrated this change now.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks Tim, I agree that it is closer to meta data than real data. I've integrated this change now.
                  Hide
                  Permalink
                  salvetore Michael de Raadt added a comment -

                  Test result: Success!

                  Tested in 2.2, 2.3 and master.

                  Show
                  salvetore Michael de Raadt added a comment - Test result: Success! Tested in 2.2, 2.3 and master.
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

                  Closing, ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      1 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        14/Jan/13