Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36667

Feedback Available mail is sent for mod_assign when no feedback is available yet if you lock assignments from further changes

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.3
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Make sure automated crons are not running
      2. Login as admin and manually run cron (/admin/cron.php)
      3. Create an assignment in a course with at least 4 students.
      4. Login as a teacher and go to the grading page for the assignment.
      5. Give the first submission a grade
      6. Lock the second submission ("Prevent submission updates" in the menu for this row)
      7. Give the second submission a grade
      8. Give the third submission a grade
      9. Lock the third submission ("Prevent submission updates" in the menu for this row)
      10. Lock the forth submission ("Prevent submission updates" in the menu for this row)
      11. Now login as admin and manually run cron again (/admin/cron.php)
      12. There will be a message in the cron output: "Done processing 3 assignment submissions"
      Show
      Make sure automated crons are not running Login as admin and manually run cron (/admin/cron.php) Create an assignment in a course with at least 4 students. Login as a teacher and go to the grading page for the assignment. Give the first submission a grade Lock the second submission ("Prevent submission updates" in the menu for this row) Give the second submission a grade Give the third submission a grade Lock the third submission ("Prevent submission updates" in the menu for this row) Lock the forth submission ("Prevent submission updates" in the menu for this row) Now login as admin and manually run cron again (/admin/cron.php) There will be a message in the cron output: "Done processing 3 assignment submissions"
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36667-master

      Description

      I've just seen this on our 2.3 site and have replicated against master.

      When a teacher locks submissions to prevent future changes, an entry is created in the assign_grades table. At present, this is the only requirement to send e-mail to students informing them that a grade and/or feedback has been left.

      This probably should check whether a grade or feedback has been left.

      Replication instructions:

      • Create a new assignment
      • Have a user submit some work to it
      • Confirm that no entry appears in the mdl_assign_grades table for it
      • Lock the assignment to prevent changes
      • Confirm that an entry does now appear in the mdl_assign_grades table for it
      • Confirm that the 'mailed' flag is currently 0
      • Run cron
      • Bug: The feedbackavail notification was sent by cron and the mailed flag set to 1 despite no feedback being available.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13