Loading...

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE
Pull from Repository:
https://github.com/scara/moodle.git
Pull Main Branch:
m28_~~MDL-36669~~_UFO_references_in_filelib
Pull Main Diff URL:
https://github.com/scara/moodle/commit/8045696b3797765c51dee1df34e05841fdcc31ca
Testing Instructions:
Hide

(difficulty: easy, requires teacher access to a course and administrator access to enable the multimedia filter)

Log in as a administrator and enable the multimedia filter;

Add an HTML file as a "File" resource and set "Use fiters ..." to "HTML";

Open the Developer Tools of you browser (<F12> for Windows) and select&enable the Network tab

Access the HTML resource: no HTTP 404 should be recorded - before applying the patch, one hit to lib/ufo.js - and no warnings should appear in the logs.
Show
(difficulty: easy, requires teacher access to a course and administrator access to enable the multimedia filter) Log in as a administrator and enable the multimedia filter; Add an HTML file as a "File" resource and set "Use fiters ..." to "HTML"; Open the Developer Tools of you browser (<F12> for Windows) and select&enable the Network tab Access the HTML resource: no HTTP 404 should be recorded - before applying the patch, one hit to lib/ufo.js - and no warnings should appear in the logs.

That file represents the UFO library which has been removed in ~~MDL-26697~~ (git hash fcd2cbaf1f99750ce1a44780ae1dad24f21078b7).

The library is included, when the media plugin filter is enabled, by filelib.php::file_modify_html_header().

has a non-specific relationship to

MDL-21120 somehow fix hardcoded page styles in manually created pages and emails

MDL-29738 Remove unused stylesheet hook

Participants:: Andrew Davis, CiBoT, Damyon Wiese, Frédéric Massart, Jakob Ackermann, Marina Glancy, Matteo Scaramuccia, Petr Skoda, Sam Hemelryk