Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36674

Cannot edit my profile when HTTPS is turn on

    Details

    • Testing Instructions:
      Hide

      Pre-requisite

      1. Server with ssl

      Test 1

      1. Login as admin
      2. Enable loginhttps (Home ► Site administration ► Security ► HTTP security)
      3. Select any course
      4. Go to "My Profile Setting" > "Edit Profile"

      Make sure you don't any error and can update profile.

      Test 2

      1. Run phpunit lib/tests/weblib_test.php
      Show
      Pre-requisite Server with ssl Test 1 Login as admin Enable loginhttps (Home ► Site administration ► Security ► HTTP security) Select any course Go to "My Profile Setting" > "Edit Profile" Make sure you don't any error and can update profile. Test 2 Run phpunit lib/tests/weblib_test.php
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      wip-mdl-36674

      Description

      Using $version = 2012062502.10 with "Use HTTPS for logins" checked;

      Well, actually it work only if I am in the front page and I go edit my profile, page is displayed correctly.
      If I'm in any course and I go to My Profile Setting >Edit Profile, I got the following error:

      [16-Nov-2012 22:20:45 UTC] Default exception handler: Coding error detected, it must be fixed by a programmer: out_as_local_url called on a non-local URL Debug: 
      Error code: codingerror
      * line 752 of \lib\weblib.php: coding_exception thrown
      * line 3564 of \lib\navigationlib.php: call to moodle_url->out_as_local_url()
      * line 3290 of \lib\navigationlib.php: call to settings_navigation->load_course_settings()
      * line 716 of \lib\pagelib.php: call to settings_navigation->initialise()
      * line 732 of \lib\pagelib.php: call to moodle_page->magic_get_settingsnav()
      * line 133 of \blocks\settings\block_settings.php: call to moodle_page->__get()
      * line 281 of \blocks\moodleblock.class.php: call to block_settings->get_content()
      * line 232 of \blocks\moodleblock.class.php: call to block_base->formatted_contents()
      * line 937 of \lib\blocklib.php: call to block_base->get_content_for_output()
      * line 989 of \lib\blocklib.php: call to block_manager->create_block_contents()
      * line 352 of \lib\blocklib.php: call to block_manager->ensure_content_created()
      * line 6 of \theme\uqat\layout\general.php: call to block_manager->region_has_content()
      * line 768 of \lib\outputrenderers.php: call to include()
      * line 715 of \lib\outputrenderers.php: call to core_renderer->render_page_layout()
      * line 299 of \user\editadvanced.php: call to core_renderer->header()

      in moodle_url->out_as_local_url, problematic lines are :

      #751       if (strpos($url, $CFG->wwwroot) !== 0) {
      #752           throw new coding_exception('out_as_local_url called on a non-local URL');

      I figures it have to do with my $CFG->wwwroot being http://moodle.uqat.ca while $url=https://moodle.uqat.ca/user/editadvanced.php?course=5&id=3387.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  13 Vote for this issue
                  Watchers:
                  21 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13