Moodle

Composer PHPUnit installation

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.4
  • Fix Version/s: 2.4
  • Component/s: Unit tests
  • Labels:
  • Testing Instructions:
    Hide

    1/ go to your moodle dirroot
    2/ install composer - see http://getcomposer.org/doc/00-intro.md
    3/ "php composer.phar install"
    4/ execute "vendor/bin/phpunit" (sorry, *nix only instructions for now)
    5/ bump up some version number
    6/ execute again and verify the init script works too
    7/ try the hidden web interface at admin/tool/phpunit/webrunner.php
    8/ repeat the testing with & without standard PHPUnit from PEAR

    Show
    1/ go to your moodle dirroot 2/ install composer - see http://getcomposer.org/doc/00-intro.md 3/ "php composer.phar install" 4/ execute "vendor/bin/phpunit" (sorry, *nix only instructions for now) 5/ bump up some version number 6/ execute again and verify the init script works too 7/ try the hidden web interface at admin/tool/phpunit/webrunner.php 8/ repeat the testing with & without standard PHPUnit from PEAR
  • Affected Branches:
    MOODLE_24_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    w47_MDL-36701_m24_composer
  • Pull Master Diff URL:

Description

should be a lot better than PEAR...

http://getcomposer.org

Sample installation of PHPUnit into moodle project:

$ cd yourmoodledir
$ curl -s https://getcomposer.org/installer | php
$ php composer.phar install

Execution of PHPUnit:

$ cd yourmoodledir
$ vendor/bin/phpunit

Upgrade to next PHPUnit version:

$ cd yourmoodledir
$ php composer.phar update

Issue Links

has been marked as being related by

Improvement - An enhancement to an existing Moodle feature. MDL-36936 Specify phpunit dependency as require-dev instead of require

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
is a clone of

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36817 Backport Composer PHPUnit installation

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
testing discovered

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36779 undefined NO_MOODLE_COOKIES on DB connection error

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda added a comment -

There is a known problem execution hints when some tests fail, for now it does not print path to the original execution script. I will fix that later...

Show
Petr Škoda added a comment - There is a known problem execution hints when some tests fail, for now it does not print path to the original execution script. I will fix that later...
Hide
Permalink
Petr Škoda added a comment -

working on some more improvements...

Show
Petr Škoda added a comment - working on some more improvements...
Hide
Permalink
Petr Škoda added a comment -

All known issues fixed.

Show
Petr Škoda added a comment - All known issues fixed.
Hide
Permalink
Tim Hunt added a comment -

I just tested on Windows 7 + Cygwin (with existing PHPunit already installed). It took me a bit of time to get composer installed since http://getcomposer.org/doc/00-intro.md#using-the-installer does not consider does not consider that you might be behind a HTTP proxy. Apart from that, it worked fine.

Nice one Petr.

Show
Tim Hunt added a comment - I just tested on Windows 7 + Cygwin (with existing PHPunit already installed). It took me a bit of time to get composer installed since http://getcomposer.org/doc/00-intro.md#using-the-installer does not consider does not consider that you might be behind a HTTP proxy. Apart from that, it worked fine. Nice one Petr.
Hide
Permalink
Aparup Banerjee added a comment -

Hm i've gotten an interesting:

moodle_page_test::test_pagetype_defaults_to_script
Failed asserting that two strings are equal.
— Expected
+++ Actual
@@ @@
-'site-index'
+'vendor-phpunit-phpunit-composer-bin-phpunit'

/Users/aparup/Sites/i/lib/tests/pagelib_test.php:191
/Users/aparup/Sites/i/lib/phpunit/classes/advanced_testcase.php:76

To re-run:
phpunit moodle_page_test lib/tests/pagelib_test.php

Show
Aparup Banerjee added a comment - Hm i've gotten an interesting: moodle_page_test::test_pagetype_defaults_to_script Failed asserting that two strings are equal. — Expected +++ Actual @@ @@ -'site-index' +'vendor-phpunit-phpunit-composer-bin-phpunit' /Users/aparup/Sites/i/lib/tests/pagelib_test.php:191 /Users/aparup/Sites/i/lib/phpunit/classes/advanced_testcase.php:76 To re-run: phpunit moodle_page_test lib/tests/pagelib_test.php
Hide
Permalink
Petr Škoda added a comment - - edited

Strange, I already tweaked the test to fix this, I will try the latest integration branch again and look for any caching problems.

Thanks!

Show
Petr Škoda added a comment - - edited Strange, I already tweaked the test to fix this, I will try the latest integration branch again and look for any caching problems. Thanks!
Hide
Permalink
Petr Škoda added a comment -

oh, the line number 191 indicates you are not using my latest version of the patch.

Show
Petr Škoda added a comment - oh, the line number 191 indicates you are not using my latest version of the patch.
Hide
Permalink
Aparup Banerjee added a comment -

ah confirmed this works for me.

Please update lib/phpunit/readme.md to reflect adding of composer support and then i guess this could go into integration now (late but i see no risk)

Show
Aparup Banerjee added a comment - ah confirmed this works for me. Please update lib/phpunit/readme.md to reflect adding of composer support and then i guess this could go into integration now (late but i see no risk)
Hide
Permalink
Petr Škoda added a comment -

oh, I completely forgot we have that readme!

fixing...

Show
Petr Škoda added a comment - oh, I completely forgot we have that readme! fixing...
Hide
Permalink
Petr Škoda added a comment -

readme updated, thanks

Show
Petr Škoda added a comment - readme updated, thanks
Hide
Permalink
Aparup Banerjee added a comment -

cool, thanks been integrated. passing this too

Show
Aparup Banerjee added a comment - cool, thanks been integrated. passing this too
Hide
Permalink
Aparup Banerjee added a comment -

both phpunit binaries work here.

the web runner (new to me) is experimental and didn't run fine for me due to very basic db connection failure very likely due to it being incomplete.

Debug info:

Warning: mysqli::mysqli() [mysqli.mysqli]: [2002] No such file or directory (trying to connect via unix:///var/mysql/mysql.sock) in /Users/aparup/Sites/i/lib/dml/mysqli_native_moodle_database.php on line 381

Warning: mysqli::mysqli() [mysqli.mysqli]: (HY000/2002): No such file or directory in /Users/aparup/Sites/i/lib/dml/mysqli_native_moodle_database.php on line 381

Error code: dbconnectionfailed
Stack trace: * line 388 of /lib/dml/mysqli_native_moodle_database.php: dml_connection_exception thrown

  • line 344 of /lib/dmllib.php: call to mysqli_native_moodle_database->connect()
  • line 479 of /lib/setup.php: call to setup_DB()
  • line 199 of /lib/phpunit/bootstrap.php: call to require()
  • line 77 of /admin/tool/phpunit/cli/util.php: call to require()

Notice: Use of undefined constant NO_MOODLE_COOKIES - assumed 'NO_MOODLE_COOKIES' in /Users/aparup/Sites/i/lib/sessionlib.php on line 168

Notice: Use of undefined constant NO_MOODLE_COOKIES - assumed 'NO_MOODLE_COOKIES' in /Users/aparup/Sites/i/lib/sessionlib.php on line 306

Notice: Use of undefined constant NO_MOODLE_COOKIES - assumed 'NO_MOODLE_COOKIES' in /Users/aparup/Sites/i/lib/sessionlib.php on line 250

Show
Aparup Banerjee added a comment - both phpunit binaries work here. the web runner (new to me) is experimental and didn't run fine for me due to very basic db connection failure very likely due to it being incomplete. Debug info: Warning: mysqli::mysqli() [mysqli.mysqli] : [2002] No such file or directory (trying to connect via unix:///var/mysql/mysql.sock) in /Users/aparup/Sites/i/lib/dml/mysqli_native_moodle_database.php on line 381 Warning: mysqli::mysqli() [mysqli.mysqli] : (HY000/2002): No such file or directory in /Users/aparup/Sites/i/lib/dml/mysqli_native_moodle_database.php on line 381 Error code: dbconnectionfailed Stack trace: * line 388 of /lib/dml/mysqli_native_moodle_database.php: dml_connection_exception thrown line 344 of /lib/dmllib.php: call to mysqli_native_moodle_database->connect() line 479 of /lib/setup.php: call to setup_DB() line 199 of /lib/phpunit/bootstrap.php: call to require() line 77 of /admin/tool/phpunit/cli/util.php: call to require() Notice: Use of undefined constant NO_MOODLE_COOKIES - assumed 'NO_MOODLE_COOKIES' in /Users/aparup/Sites/i/lib/sessionlib.php on line 168 Notice: Use of undefined constant NO_MOODLE_COOKIES - assumed 'NO_MOODLE_COOKIES' in /Users/aparup/Sites/i/lib/sessionlib.php on line 306 Notice: Use of undefined constant NO_MOODLE_COOKIES - assumed 'NO_MOODLE_COOKIES' in /Users/aparup/Sites/i/lib/sessionlib.php on line 250
Hide
Permalink
Petr Škoda added a comment -

Interesting, it worked fine for me when I tested it without any problems, I will try the webrunner again and file new issues if necessary.

Show
Petr Škoda added a comment - Interesting, it worked fine for me when I tested it without any problems, I will try the webrunner again and file new issues if necessary.
Hide
Permalink
Petr Škoda added a comment -

The reason might be that webrunner uses different PHP because it runs under your apache account which may have different paths.

I am afraid we can not do much about that, it is experimental feature used mostly by OU...

Show
Petr Škoda added a comment - The reason might be that webrunner uses different PHP because it runs under your apache account which may have different paths. I am afraid we can not do much about that, it is experimental feature used mostly by OU...
Hide
Permalink
Petr Škoda added a comment -

here is the new issue for NO_MOODLE_COOKIES: MDL-36779

Show
Petr Škoda added a comment - here is the new issue for NO_MOODLE_COOKIES: MDL-36779
Hide
Permalink
Petr Škoda added a comment -

Documented at http://docs.moodle.org/dev/PHPUnit, I am going to blog about it too.

Show
Petr Škoda added a comment - Documented at http://docs.moodle.org/dev/PHPUnit , I am going to blog about it too.
Hide
Permalink
Dan Poltawski added a comment -

Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

ciao
Dan

Show
Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan
Hide
Permalink
David Monllaó added a comment - - edited

Hi,

I like this issue I see that phpunit is declared as a 'require' package, composer has the 'require-dev' attribute which is more appropriate for dev/test purposes, if in future Moodle intends to use composer to manage other libraries dependencies (used by Moodle core) this package could be moved to 'require-dev'. The only difference using this attribute instead of 'require' is that composer has to be executed with --dev option (http://getcomposer.org/doc/04-schema.md#require-dev)

Show
David Monllaó added a comment - - edited Hi, I like this issue I see that phpunit is declared as a 'require' package, composer has the 'require-dev' attribute which is more appropriate for dev/test purposes, if in future Moodle intends to use composer to manage other libraries dependencies (used by Moodle core) this package could be moved to 'require-dev'. The only difference using this attribute instead of 'require' is that composer has to be executed with --dev option ( http://getcomposer.org/doc/04-schema.md#require-dev )
Hide
Permalink
Petr Škoda added a comment -

Good idea, could you please create a new issue for 2.5dev, I suppose it should not be a problem to change it there.

Show
Petr Škoda added a comment - Good idea, could you please create a new issue for 2.5dev, I suppose it should not be a problem to change it there.
Hide
Permalink
Aparup Banerjee added a comment -

note: 'require-dev' suggestion is implemented in MDL-36936 and backported via MDL-36817.

Show
Aparup Banerjee added a comment - note: 'require-dev' suggestion is implemented in MDL-36936 and backported via MDL-36817 .

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: