Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36704

Wrap activity condition rules in some tag

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.3.3
    • Fix Version/s: None
    • Component/s: Activity completion
    • Labels:
    • Testing Instructions:
      Hide

      1. Set a date condition on an activity so that it is not available to students (it should be set to display but greyed-out).
      2. Log in as a student.
      3. Using tools in your browser, examine the HTML code for the text that warns about the activity not being available yet.

      • It should be contained in a span with the classes 'conditionalrule requires_date'
        4. Run unit tests for conditionlib (or as part of all the unit tests)
      • Unit tests for conditionlib should pass.
      Show
      1. Set a date condition on an activity so that it is not available to students (it should be set to display but greyed-out). 2. Log in as a student. 3. Using tools in your browser, examine the HTML code for the text that warns about the activity not being available yet. It should be contained in a span with the classes 'conditionalrule requires_date' 4. Run unit tests for conditionlib (or as part of all the unit tests) Unit tests for conditionlib should pass.
    • Affected Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-36704-master

      Description

      If an activity has a lot of rules for conditional availability, you tend to get a wall of text that's pretty impossible to read. Here's a simple patch that just wraps each one in a <span> tag with some classes to allow a theme to display them a little cleaner.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                quen Sam Marshall
                Reporter:
                jk3us Jay Knight
                Peer reviewer:
                Sam Marshall
                Integrator:
                Dan Poltawski
                Tester:
                Rajesh Taneja
                Participants:
                Component watchers:
                Sam Marshall, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: