Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Goto calendar>manage subscription
      2. Try submiting the form with the following:-
      • method as url and empty url
      • method as url and incorrect url
      • method as file and empty file area
      • method as file and wrong format file
      1. Make sure error is generated in each case
      2. Now try submitting correct file and url and make sure everything works as expected.
      Show
      Goto calendar>manage subscription Try submiting the form with the following:- method as url and empty url method as url and incorrect url method as file and empty file area method as file and wrong format file Make sure error is generated in each case Now try submitting correct file and url and make sure everything works as expected.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-36710-master

      Description

      When the file import mode is choosen, We should not allow the form to be submitted without a file.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Blocked issue must be resolved first for proper testing.

            Show
            ankit_frenz Ankit Agarwal added a comment - Blocked issue must be resolved first for proper testing.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Hello Ankit, patch looks good but it seems you missed to clean debug msg.
            https://github.com/ankitagarwal/moodle/commit/820810158d3b67887c3a4bb3d8aae840d5793e74#L0R114

            Also, it might be nice to have few more brackets in https://github.com/ankitagarwal/moodle/commit/820810158d3b67887c3a4bb3d8aae840d5793e74#L0R126

            Show
            rajeshtaneja Rajesh Taneja added a comment - Hello Ankit, patch looks good but it seems you missed to clean debug msg. https://github.com/ankitagarwal/moodle/commit/820810158d3b67887c3a4bb3d8aae840d5793e74#L0R114 Also, it might be nice to have few more brackets in https://github.com/ankitagarwal/moodle/commit/820810158d3b67887c3a4bb3d8aae840d5793e74#L0R126
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Thanks Raj for the review.
            I have updated the patch, submitting for integration.
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Thanks Raj for the review. I have updated the patch, submitting for integration. Thanks
            Hide
            nebgor Aparup Banerjee added a comment -

            Thats been integrated into master now, Namaste.

            Show
            nebgor Aparup Banerjee added a comment - Thats been integrated into master now, Namaste.
            Hide
            salvetore Michael de Raadt added a comment -

            Testing this and the related QA test...

            Show
            salvetore Michael de Raadt added a comment - Testing this and the related QA test...
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi aparup, I have made a quick fix to the issue Michael found with this.
            Please pull the commit in integration.
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi aparup, I have made a quick fix to the issue Michael found with this. Please pull the commit in integration. Thanks
            Hide
            nebgor Aparup Banerjee added a comment -

            done, works here too. (note: issue/fix was to allow submission of valid urls )

            Show
            nebgor Aparup Banerjee added a comment - done, works here too. (note: issue/fix was to allow submission of valid urls )
            Hide
            salvetore Michael de Raadt added a comment -

            Test result: Success!

            Works a treat.

            Show
            salvetore Michael de Raadt added a comment - Test result: Success! Works a treat.
            Hide
            nebgor Aparup Banerjee added a comment -

            ah i did note with Ankit that the url type (or file at the endpoint of it) wasn't being validated but that would probably be an improvement issue and a little overkill.

            anyway, yum! thanks for the treat!

            Show
            nebgor Aparup Banerjee added a comment - ah i did note with Ankit that the url type (or file at the endpoint of it) wasn't being validated but that would probably be an improvement issue and a little overkill. anyway, yum! thanks for the treat!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Y E S !

            Closing as fixed, many thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12