Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Goto calendar>manage subscription
      2. Try submiting the form with the following:-
      • method as url and empty url
      • method as url and incorrect url
      • method as file and empty file area
      • method as file and wrong format file
      1. Make sure error is generated in each case
      2. Now try submitting correct file and url and make sure everything works as expected.
      Show
      Goto calendar>manage subscription Try submiting the form with the following:- method as url and empty url method as url and incorrect url method as file and empty file area method as file and wrong format file Make sure error is generated in each case Now try submitting correct file and url and make sure everything works as expected.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-36710-master
    • Rank:
      46214

      Description

      When the file import mode is choosen, We should not allow the form to be submitted without a file.

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          Blocked issue must be resolved first for proper testing.

          Show
          Ankit Agarwal added a comment - Blocked issue must be resolved first for proper testing.
          Hide
          Rajesh Taneja added a comment -

          Hello Ankit, patch looks good but it seems you missed to clean debug msg.
          https://github.com/ankitagarwal/moodle/commit/820810158d3b67887c3a4bb3d8aae840d5793e74#L0R114

          Also, it might be nice to have few more brackets in https://github.com/ankitagarwal/moodle/commit/820810158d3b67887c3a4bb3d8aae840d5793e74#L0R126

          Show
          Rajesh Taneja added a comment - Hello Ankit, patch looks good but it seems you missed to clean debug msg. https://github.com/ankitagarwal/moodle/commit/820810158d3b67887c3a4bb3d8aae840d5793e74#L0R114 Also, it might be nice to have few more brackets in https://github.com/ankitagarwal/moodle/commit/820810158d3b67887c3a4bb3d8aae840d5793e74#L0R126
          Hide
          Ankit Agarwal added a comment -

          Thanks Raj for the review.
          I have updated the patch, submitting for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks Raj for the review. I have updated the patch, submitting for integration. Thanks
          Hide
          Aparup Banerjee added a comment -

          Thats been integrated into master now, Namaste.

          Show
          Aparup Banerjee added a comment - Thats been integrated into master now, Namaste.
          Hide
          Michael de Raadt added a comment -

          Testing this and the related QA test...

          Show
          Michael de Raadt added a comment - Testing this and the related QA test...
          Hide
          Ankit Agarwal added a comment -

          Hi aparup, I have made a quick fix to the issue Michael found with this.
          Please pull the commit in integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Hi aparup, I have made a quick fix to the issue Michael found with this. Please pull the commit in integration. Thanks
          Hide
          Aparup Banerjee added a comment -

          done, works here too. (note: issue/fix was to allow submission of valid urls )

          Show
          Aparup Banerjee added a comment - done, works here too. (note: issue/fix was to allow submission of valid urls )
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          Works a treat.

          Show
          Michael de Raadt added a comment - Test result: Success! Works a treat.
          Hide
          Aparup Banerjee added a comment -

          ah i did note with Ankit that the url type (or file at the endpoint of it) wasn't being validated but that would probably be an improvement issue and a little overkill.

          anyway, yum! thanks for the treat!

          Show
          Aparup Banerjee added a comment - ah i did note with Ankit that the url type (or file at the endpoint of it) wasn't being validated but that would probably be an improvement issue and a little overkill. anyway, yum! thanks for the treat!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Y E S !

          Closing as fixed, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: