Details

    • Testing Instructions:
      Hide
      1. Enable activity completion on site and course level
      2. Add some activities with different completion systems (automatic, student, ...)
      3. Check the course page with editing mode as an admin
      4. Check the course page with editind mode OFF as an admin
      5. Check the course page as a student
      6. Do some stuff to turn the status of the icons (pass, fail, click, view the activity, ...)
      7. Make sure the icons look nice and the PNG fallback works
      Show
      Enable activity completion on site and course level Add some activities with different completion systems (automatic, student, ...) Check the course page with editing mode as an admin Check the course page with editind mode OFF as an admin Check the course page as a student Do some stuff to turn the status of the icons (pass, fail, click, view the activity, ...) Make sure the icons look nice and the PNG fallback works
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36718-master
    • Rank:
      46222

      Description

      Activity completion icons

        Activity

        Hide
        Frédéric Massart added a comment -

        Note: The switch to blue for pix/i/completion-auto-y.png was decided because red often means failure, or some negative status, which does not make sense when the activity is "complete". Also, pix/i/completion-auto-fail.png is now red instead of black not to confuse with a ticked checkbox.

        Show
        Frédéric Massart added a comment - Note: The switch to blue for pix/i/completion-auto-y.png was decided because red often means failure, or some negative status, which does not make sense when the activity is "complete". Also, pix/i/completion-auto-fail.png is now red instead of black not to confuse with a ticked checkbox.
        Hide
        Sam Hemelryk added a comment -

        Hi Fred,

        Who else has seen these icons?
        If Barbara/Martin havn't I think it would be best to include them here before these get integrated.

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Hi Fred, Who else has seen these icons? If Barbara/Martin havn't I think it would be best to include them here before these get integrated. Many thanks Sam
        Hide
        Barbara Ramiro added a comment -

        Hi Sam,

        I actually designed the icons and picked the colors that best represent the context considering the colors used on other areas/modules such as quiz etc. The idea is to use red for something that needs attention and green for go or ok and blue to something neutral. Also, this morning, Fred and I had a meeting with Martin about the completion icons and its been agreed to keep the proposed colors but needs a bit of tweaking to make a distinction between the auto icons and the manual. Will revise it today and let us know what you think.

        Cheers,
        Barbara

        Show
        Barbara Ramiro added a comment - Hi Sam, I actually designed the icons and picked the colors that best represent the context considering the colors used on other areas/modules such as quiz etc. The idea is to use red for something that needs attention and green for go or ok and blue to something neutral. Also, this morning, Fred and I had a meeting with Martin about the completion icons and its been agreed to keep the proposed colors but needs a bit of tweaking to make a distinction between the auto icons and the manual. Will revise it today and let us know what you think. Cheers, Barbara
        Hide
        Martin Dougiamas added a comment -

        The current icons, if you really look at them, are odd and it's easy to get confused and have to resort to using tooltips.

        After some discussion we settled on some changes here to make the images more consistent without changing them overall too much:

        auto-n —> dotted box (empty)
        auto-y -> dotted box with blue tick
        auto-fail -> dotted box with red cross
        auto-pass -> dotted box with green tick
        manual-y -> solid box with blue tick

        Barbara will post a screenshot here.

        Show
        Martin Dougiamas added a comment - The current icons, if you really look at them, are odd and it's easy to get confused and have to resort to using tooltips. After some discussion we settled on some changes here to make the images more consistent without changing them overall too much: auto-n —> dotted box (empty) auto-y -> dotted box with blue tick auto-fail -> dotted box with red cross auto-pass -> dotted box with green tick manual-y -> solid box with blue tick Barbara will post a screenshot here.
        Hide
        Martin Dougiamas added a comment -

        (and in case anyone points out that a blue-green blind person will have trouble distinguishing auto-pass and auto-y, they are basically the same thing for students anyway so it doesn't matter )

        Show
        Martin Dougiamas added a comment - (and in case anyone points out that a blue-green blind person will have trouble distinguishing auto-pass and auto-y, they are basically the same thing for students anyway so it doesn't matter )
        Hide
        Frédéric Massart added a comment -

        Sam those icons were designed by Barbara, my mistake for forgetting to set her as author as I usually do. We discussed them with Martin and here is the final version. Pushing for integration again. Thanks!

        Show
        Frédéric Massart added a comment - Sam those icons were designed by Barbara, my mistake for forgetting to set her as author as I usually do. We discussed them with Martin and here is the final version. Pushing for integration again. Thanks!
        Hide
        Dan Poltawski added a comment -

        The icons to me look a little bit 'clipped' on the right edge, so just holding off briefly to get a +1 from MD.

        Show
        Dan Poltawski added a comment - The icons to me look a little bit 'clipped' on the right edge, so just holding off briefly to get a +1 from MD.
        Hide
        Dan Poltawski added a comment -

        Integrated, thanks guys.

        Show
        Dan Poltawski added a comment - Integrated, thanks guys.
        Hide
        Dan Poltawski added a comment -

        Tested during integration. Looks great.

        Show
        Dan Poltawski added a comment - Tested during integration. Looks great.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Y E S !

        Closing as fixed, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: