Moodle
  1. Moodle
  2. MDL-36728

'Require that students accept the submission statement' setting should not be available if there is no submission statement

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. As an admin user, go to "Site Administration -> Plugins -> Activity modules -> Assignment"
      2. Set the text for the assign | submissionstatement to empty and save the settings
      3. Add an assignment to a course, on the module settings page there will be no setting for "Require that students accept the submission statement"
      4. Go back to the "Site Administration -> Plugins -> Activity modules -> Assignment" page
      5. Set the text for the assign | submissionstatement to "Hello", leave "Require that students accept the submission statement" unchecked and save the settings
      6. Add an assignment to a course, on the module settings page there will be a setting for "Require that students accept the submission statement"
      7. The help text for the setting will not refer to "this entire Moodle installation."
      Show
      As an admin user, go to "Site Administration -> Plugins -> Activity modules -> Assignment" Set the text for the assign | submissionstatement to empty and save the settings Add an assignment to a course, on the module settings page there will be no setting for "Require that students accept the submission statement" Go back to the "Site Administration -> Plugins -> Activity modules -> Assignment" page Set the text for the assign | submissionstatement to "Hello", leave "Require that students accept the submission statement" unchecked and save the settings Add an assignment to a course, on the module settings page there will be a setting for "Require that students accept the submission statement" The help text for the setting will not refer to "this entire Moodle installation."
    • Workaround:
      Hide

      Provide a default submission statement, such as "I certify that this is my own work." or similar.

      Show
      Provide a default submission statement, such as "I certify that this is my own work." or similar.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-36728-master
    • Rank:
      46232

      Description

      If a teacher creates a new assignment, the setting 'Require that students accept the submission statement' is available even when an admin has not entered a submission statement (with "Require that students accept the submission statement" left as default no). This is confusing for the teacher, since if they set it to Yes, then no submission statement is shown to students.

      A possible solution would be to have a default submission statement, such as "I certify that this is my own work." or similar.

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          I also found the help text for this setting at the assignment level was re-using the text for the admin setting which did not make sense. I have fixed that and added AMOS commands to copy the title for the new help text.

          Show
          Damyon Wiese added a comment - I also found the help text for this setting at the assignment level was re-using the text for the admin setting which did not make sense. I have fixed that and added AMOS commands to copy the title for the new help text.
          Hide
          Damyon Wiese added a comment -

          I also added a default value for the submission statement: "This assignment is all my own work and I have acknowledged any use of the works of other people."

          Show
          Damyon Wiese added a comment - I also added a default value for the submission statement: "This assignment is all my own work and I have acknowledged any use of the works of other people."
          Hide
          Damyon Wiese added a comment -

          Thanks Helen,

          I'm sending this for integration now.

          Regards, Damyon

          Show
          Damyon Wiese added a comment - Thanks Helen, I'm sending this for integration now. Regards, Damyon
          Hide
          Damyon Wiese added a comment -

          Just updated my branch names as they had the wrong issue number.

          Show
          Damyon Wiese added a comment - Just updated my branch names as they had the wrong issue number.
          Hide
          Michael de Raadt added a comment -

          Hi, Damyon.

          The default statement is self-contradictory.

          "This assignment is all my own work and I have acknowledged any use of the works of other people."

          Perhaps, instead, it could be phrased:

          "This assignment is my own work, except where I have acknowledged the use of the works of other people."

          Show
          Michael de Raadt added a comment - Hi, Damyon. The default statement is self-contradictory. "This assignment is all my own work and I have acknowledged any use of the works of other people." Perhaps, instead, it could be phrased: "This assignment is my own work, except where I have acknowledged the use of the works of other people."
          Hide
          Damyon Wiese added a comment -

          Sure - I'm happy with that change - I'll update the branches.

          Show
          Damyon Wiese added a comment - Sure - I'm happy with that change - I'll update the branches.
          Hide
          Damyon Wiese added a comment -

          That language change has been added to the branches - it now reads "This assignment is my own work, except where I have acknowledged the use of the works of other people."

          Show
          Damyon Wiese added a comment - That language change has been added to the branches - it now reads "This assignment is my own work, except where I have acknowledged the use of the works of other people."
          Hide
          Sam Hemelryk added a comment -

          Thanks Damyon, this has been integrated now.

          Just noting I had to cherry-pick the commit and amend it as you had the wrong tracker issue number on there.

          Show
          Sam Hemelryk added a comment - Thanks Damyon, this has been integrated now. Just noting I had to cherry-pick the commit and amend it as you had the wrong tracker issue number on there.
          Hide
          Rossiani Wijaya added a comment -

          Hi Damyon,

          I noticed string error in 63 of /mod/assign/settings.php: call to get_string().

          String is defined as 'submissionstatementdefault' but used as 'submissionstatement_default'

          Show
          Rossiani Wijaya added a comment - Hi Damyon, I noticed string error in 63 of /mod/assign/settings.php: call to get_string(). String is defined as 'submissionstatementdefault' but used as 'submissionstatement_default'
          Hide
          Damyon Wiese added a comment -

          Thanks Rosie,

          I have pushed a new branch based on the current integration master, which adds a new patch to fix this (I made this a new branch because Sam had amended by original patch).

          The branch is MDL-36728-master-u1

          Show
          Damyon Wiese added a comment - Thanks Rosie, I have pushed a new branch based on the current integration master, which adds a new patch to fix this (I made this a new branch because Sam had amended by original patch). The branch is MDL-36728 -master-u1
          Hide
          Sam Hemelryk added a comment -

          Awesome thanks for picking that up Rosie, and for providing the fix Damyon.
          Its been integrated now and this is ready for testing once more.

          Show
          Sam Hemelryk added a comment - Awesome thanks for picking that up Rosie, and for providing the fix Damyon. Its been integrated now and this is ready for testing once more.
          Hide
          Jason Fowler added a comment -

          Works as described Damyon

          Show
          Jason Fowler added a comment - Works as described Damyon
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Y E S !

          Closing as fixed, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!
          Hide
          Mary Cooch added a comment -

          Removing docs_required as I've updated the information here http://docs.moodle.org/24/en/Assignment_settings

          Show
          Mary Cooch added a comment - Removing docs_required as I've updated the information here http://docs.moodle.org/24/en/Assignment_settings

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: