Moodle
  1. Moodle
  2. MDL-36732

CLOZE Question Doesn't Display Correct Answer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.3, 2.2.6, 2.3.3, 2.4
    • Fix Version/s: 2.2.7, 2.3.4, 2.4.1
    • Component/s: Quiz
    • Labels:
      None
    • Testing Instructions:
      Hide

      I suggest that you test this by logging in as teacher in one browser, and student in another, because you will need to keep changing one option, and see what effect that has from the student's point of view.

      1. As teacher, create a quiz. For simplicity, don't set a time limit or a close date.

      2. Add a Cloze question (http://docs.moodle.org/23/en/Embedded_Answers_%28Cloze%29_question_type#Examples), and then add a couple of other questions on the same page, for comparison. (E.g. a shortanswer and a multiple-choice.) Make sure these questions have feedback for individual choices / answers.

      3. Now attempt the quiz as student and submit it, so you are looking at the review page.

      4. Now, as teacher, go to the quiz settings form, and set different combinations of the Review options, Later while the quiz is still open. You should particularly focus on the Whether correct, Marks, Specific feedback and Right answer options.

      5. For each combination of options, re-load the student's review page, and make sure that the right bits of the feedback are visible or hidden. Note that for Cloze, the feedback is in a tool-tip that only appears when you mouse-over parts of the question.

      Show
      I suggest that you test this by logging in as teacher in one browser, and student in another, because you will need to keep changing one option, and see what effect that has from the student's point of view. 1. As teacher, create a quiz. For simplicity, don't set a time limit or a close date. 2. Add a Cloze question ( http://docs.moodle.org/23/en/Embedded_Answers_%28Cloze%29_question_type#Examples ), and then add a couple of other questions on the same page, for comparison. (E.g. a shortanswer and a multiple-choice.) Make sure these questions have feedback for individual choices / answers. 3. Now attempt the quiz as student and submit it, so you are looking at the review page. 4. Now, as teacher, go to the quiz settings form, and set different combinations of the Review options, Later while the quiz is still open. You should particularly focus on the Whether correct, Marks, Specific feedback and Right answer options. 5. For each combination of options, re-load the student's review page, and make sure that the right bits of the feedback are visible or hidden. Note that for Cloze, the feedback is in a tool-tip that only appears when you mouse-over parts of the question.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      46236

      Description

      CLOZE Question Doesn't Display Correct Answer when student reviews

      Steps to duplicate:
      Create quiz (settings in screenshot #1); Add questions; Demo student takes quiz and submits; After it closes, review does not show correct answer - screenshot #2 shows single CLOZE, multichoice CLOZE, a short answer, and a multiple choice. Correct answer is not displayed for either CLOZE question.

      Expectation is a yellow box containing the correct answer as for short answer and multiple choice type questions

      1. Master.png
        75 kB
      2. ScreenShot_1.png
        55 kB
      3. ScreenShot_2.png
        123 kB
      4. Stable22.png
        61 kB

        Activity

        Hide
        Tim Hunt added a comment -

        The Correct answer appears in a tool-tip when you hover over a part of the question, just like the other feedback does.

        Show
        Tim Hunt added a comment - The Correct answer appears in a tool-tip when you hover over a part of the question, just like the other feedback does.
        Hide
        Dave Laurie added a comment -

        Hmmm... not in our installation. I read that elsewhere but hovering over the questions shows nothing.

        Is this something that varies across themes? And if so, would you be so kind as to let me know the css calls that we may be missing?

        Regards,
        Dave

        Show
        Dave Laurie added a comment - Hmmm... not in our installation. I read that elsewhere but hovering over the questions shows nothing. Is this something that varies across themes? And if so, would you be so kind as to let me know the css calls that we may be missing? Regards, Dave
        Hide
        Tim Hunt added a comment -

        It should work in all themes.

        Try hovering over the tick or cross icon.

        Use a tool like Firebug to see if there are any JavaScript errors.

        Show
        Tim Hunt added a comment - It should work in all themes. Try hovering over the tick or cross icon. Use a tool like Firebug to see if there are any JavaScript errors.
        Hide
        Dave Laurie added a comment -

        By tick and cross, I am assuming you mean the right/wrong icons? If so, then nothing. No errors shown in Firebug javascript either. The source code for those icons don't even have any actions associated with them.

        I was wondering if our custom theme was the issue?

        Show
        Dave Laurie added a comment - By tick and cross, I am assuming you mean the right/wrong icons? If so, then nothing. No errors shown in Firebug javascript either. The source code for those icons don't even have any actions associated with them. I was wondering if our custom theme was the issue?
        Hide
        Tim Hunt added a comment -

        It is almost certainly your custom theme. Can you try switching to a standard theme on your test server, to confirm that the standard themes work for you.

        Once you know that, you can start investigating what is different in your theme.

        Show
        Tim Hunt added a comment - It is almost certainly your custom theme. Can you try switching to a standard theme on your test server, to confirm that the standard themes work for you. Once you know that, you can start investigating what is different in your theme.
        Hide
        Dave Laurie added a comment -

        Hi again, I switched the theme back to Standard and still do not see any tooltip.

        Firebug shows no html associated with the tick or cross (right wrong) icons that would call anything here.

        Any other suggestions for troubleshooting this?

        Show
        Dave Laurie added a comment - Hi again, I switched the theme back to Standard and still do not see any tooltip. Firebug shows no html associated with the tick or cross (right wrong) icons that would call anything here. Any other suggestions for troubleshooting this?
        Hide
        Dave Laurie added a comment -

        Just had an aha ... it is only in the student review mode that no tooltip appears. Instructor role views the tooltip just fine, even in our custom theme.

        This particular request was for just that: students to review cloze correct answers. The quiz review settings are correct (as are the capabilities I'm guessing) since the review of other question types works fine in student view (as shown in screenshot).

        Any ideas on what I should try next to make this happen?

        Show
        Dave Laurie added a comment - Just had an aha ... it is only in the student review mode that no tooltip appears. Instructor role views the tooltip just fine, even in our custom theme. This particular request was for just that: students to review cloze correct answers. The quiz review settings are correct (as are the capabilities I'm guessing) since the review of other question types works fine in student view (as shown in screenshot). Any ideas on what I should try next to make this happen?
        Hide
        Tim Hunt added a comment -

        Ah! perhaps it is because you have 'Specific feedback' turned off.

        Yes. I see the problem in the code now. It that option is off, the tool-tip is not displayed at all, even if it should be there, and contain other information.

        Show
        Tim Hunt added a comment - Ah! perhaps it is because you have 'Specific feedback' turned off. Yes. I see the problem in the code now. It that option is off, the tool-tip is not displayed at all, even if it should be there, and contain other information.
        Hide
        Tim Hunt added a comment -

        Thanks for you patience in helping to track this down Dave.

        Show
        Tim Hunt added a comment - Thanks for you patience in helping to track this down Dave.
        Hide
        Dan Poltawski added a comment -

        Integrated to master, 24, 23 and 22. Thanks Tim.

        Show
        Dan Poltawski added a comment - Integrated to master, 24, 23 and 22. Thanks Tim.
        Hide
        Rajesh Taneja added a comment -

        Thanks Tim,

        Works Great.

        FYI: On 22 short answer is not showing mark and "Weather correct". Probably another issue. (Screenshot attached.)

        Show
        Rajesh Taneja added a comment - Thanks Tim, Works Great. FYI: On 22 short answer is not showing mark and "Weather correct". Probably another issue. (Screenshot attached.)
        Hide
        Tim Hunt added a comment -

        Thanks Raj. What were the review options in 2.2? It looks like it is no showing Whether correct for either question, and I am pretty sure this is the sort of thing users would report quickly if it was broken. Anyway, as you say, a different issue.

        Show
        Tim Hunt added a comment - Thanks Raj. What were the review options in 2.2? It looks like it is no showing Whether correct for either question, and I am pretty sure this is the sort of thing users would report quickly if it was broken. Anyway, as you say, a different issue.
        Hide
        Rajesh Taneja added a comment -

        Hi Tim,
        I selected all options in 2.2, as well. This can be validated by cloze popup (showing mark and correct/incorrect)

        It works perfect in master

        Show
        Rajesh Taneja added a comment - Hi Tim, I selected all options in 2.2, as well. This can be validated by cloze popup (showing mark and correct/incorrect) It works perfect in master
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: