Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Accessibility, Course
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Create a assignment activity with "Allow access from" condition to be set in future.
      3. Go to course page and check "availability information" is visible
      4. Turn editing on and hide activity.
      5. Make sure "availability information" is not visible
      6. Turn editing off and "availability information" should not be visible
      7. Edit activity and change "Allow access from" in past and repeat above steps.
      Show
      Log in as admin Create a assignment activity with "Allow access from" condition to be set in future. Go to course page and check "availability information" is visible Turn editing on and hide activity. Make sure "availability information" is not visible Turn editing off and "availability information" should not be visible Edit activity and change "Allow access from" in past and repeat above steps.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      wip-mdl-36736
    • Rank:
      46241

      Description

      While hiding activity availability information on course page, it should use hide and not accesshide. As, it will give wrong information to accessibility users.

        Activity

        Hide
        Rajesh Taneja added a comment -

        Have added 2 commits:

        1. Replace accesshide with hide, as this will show consistent information to accessibility users and other users.
        2. Availability information should not be added if module is hidden as it's not a valid information for hidden module. But the exception to it is when user is editing, we have to add this information on page but hide it from user. This is needed to show availability information when user un-hide module
        Show
        Rajesh Taneja added a comment - Have added 2 commits: Replace accesshide with hide, as this will show consistent information to accessibility users and other users. Availability information should not be added if module is hidden as it's not a valid information for hidden module. But the exception to it is when user is editing, we have to add this information on page but hide it from user. This is needed to show availability information when user un-hide module
        Hide
        Frédéric Massart added a comment -

        Thanks Raj. It makes sense to me. Perhaps you could rename the variable ACCESSHIDECLASS to something more descriptive such as 'HIDECLASS' as it's not an accesshide class any more. We would usually not do that, but IIRC you introduced this variable a couple of days ago.
        Cheers!

        Show
        Frédéric Massart added a comment - Thanks Raj. It makes sense to me. Perhaps you could rename the variable ACCESSHIDECLASS to something more descriptive such as 'HIDECLASS' as it's not an accesshide class any more. We would usually not do that, but IIRC you introduced this variable a couple of days ago. Cheers!
        Hide
        Rajesh Taneja added a comment -

        Thanks Fred,

        I have changed name from ACCESSHIDECLASS to HIDECLASS. Pushing for integration.

        Show
        Rajesh Taneja added a comment - Thanks Fred, I have changed name from ACCESSHIDECLASS to HIDECLASS. Pushing for integration.
        Hide
        Dan Poltawski added a comment -

        Please can you explain in this issue what this is for from a user point of view? I see it has the qa flag, what QA test does this relate to?

        Can you make it clear in the code why are we printing out any html if we're just going to hide it in CSS as this is a very unusual approach.

        Show
        Dan Poltawski added a comment - Please can you explain in this issue what this is for from a user point of view? I see it has the qa flag, what QA test does this relate to? Can you make it clear in the code why are we printing out any html if we're just going to hide it in CSS as this is a very unusual approach.
        Hide
        Rajesh Taneja added a comment -

        Hi! Dan,

        We should not print availability information if activity is hidden, as it lose it's meaning if activity is hidden.
        But while editing this information is required to be in html so we can show/hide depending on user action of show/hide activity. Otherwise we have to do ajax query to get this information for every activity user is changing visibility for.

        This was marked MDLQA, as meta MDL-36707 had MDLQA.

        Show
        Rajesh Taneja added a comment - Hi! Dan, We should not print availability information if activity is hidden, as it lose it's meaning if activity is hidden. But while editing this information is required to be in html so we can show/hide depending on user action of show/hide activity. Otherwise we have to do ajax query to get this information for every activity user is changing visibility for. This was marked MDLQA, as meta MDL-36707 had MDLQA.
        Hide
        Dan Poltawski added a comment -

        I've missed the slot for this one.

        Show
        Dan Poltawski added a comment - I've missed the slot for this one.
        Hide
        Dan Poltawski added a comment -

        Integrated, thanks Raj.

        Show
        Dan Poltawski added a comment - Integrated, thanks Raj.
        Hide
        Mark Nelson added a comment -

        Works as expected. Passing.

        Show
        Mark Nelson added a comment - Works as expected. Passing.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Changes are now upstream, thanks for your collaboration!

        If you are going to have any celebration next days, enjoy with your gang, if not, too!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Changes are now upstream, thanks for your collaboration! If you are going to have any celebration next days, enjoy with your gang, if not, too! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: