Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.3
    • Fix Version/s: 2.5
    • Component/s: Libraries
    • Labels:

      Description

      Deprecated for Moodle 2.0 in MDL-21695

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Andrew Nicols added a comment -

            Not really a regression, but it was caused by this...

            Show
            Andrew Nicols added a comment - Not really a regression, but it was caused by this...
            Hide
            Petr Skoda added a comment -

            Thanks for the report.

            Show
            Petr Skoda added a comment - Thanks for the report.
            Hide
            Andrew Nicols added a comment -

            This deprecates old_help_icon as per the deprecation specification.

            I'm not sure how to test this given that there are no uses of it in core.

            Show
            Andrew Nicols added a comment - This deprecates old_help_icon as per the deprecation specification. I'm not sure how to test this given that there are no uses of it in core.
            Hide
            Sam Hemelryk added a comment -

            Its nice to start down the track of cleaning that. Surely it has been spitting out debugging notices long enough and it is time to throw exceptions.

            Code looks spot on thanks Andrew.

            Show
            Sam Hemelryk added a comment - Its nice to start down the track of cleaning that. Surely it has been spitting out debugging notices long enough and it is time to throw exceptions. Code looks spot on thanks Andrew.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Sorry, but you're dropping support for:

            • helpbutton()
            • doc_link()
            • popup_form()

            and, internally...

            • old_help_icon()/set_old_help_icon()

            And it seems that there are still some uses to fix:

            grep -rnP '\b(helpbutton|doc_link|popup_form|(set_)?old_help_icon)\(' * | \
                grep -vP '(this|OUTPUT)->doc_link'
            ...
            ...
            lib/deprecatedlib.php:1944:  return helpbutton('editorsh.....
            mod/wiki/pagelib.php:1314:   $table->head = array(helpbutton('diff', 'd....
            ...
            ...
            

            I've quick-looked for the others and haven't found any use (but the deprecated declaration/messages).

            So reopening...ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Sorry, but you're dropping support for: helpbutton() doc_link() popup_form() and, internally... old_help_icon()/set_old_help_icon() And it seems that there are still some uses to fix: grep -rnP '\b(helpbutton|doc_link|popup_form|(set_)?old_help_icon)\(' * | \ grep -vP '(this|OUTPUT)->doc_link' ... ... lib/deprecatedlib.php:1944: return helpbutton('editorsh..... mod/wiki/pagelib.php:1314: $table->head = array(helpbutton('diff', 'd.... ... ... I've quick-looked for the others and haven't found any use (but the deprecated declaration/messages). So reopening...ciao
            Hide
            CiBoT added a comment -

            Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

            Show
            CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
            Hide
            Andrew Nicols added a comment -

            The two locations you've found are actually both commented-out code.
            I've removed these two instances too.

            Resubmitting for rejection

            Show
            Andrew Nicols added a comment - The two locations you've found are actually both commented-out code. I've removed these two instances too. Resubmitting for rejection
            Hide
            Eloy Lafuente (stronk7) added a comment -

            LOL! Better deleted anyway.

            Show
            Eloy Lafuente (stronk7) added a comment - LOL! Better deleted anyway.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            Michael de Raadt added a comment -

            Test result: Yeah, OK.

            I tested this by running a test script to call the function...

            $OUTPUT->old_help_icon('asd','asd');
            

            ...and it produced the expected result...

            !!! Coding error detected, it must be fixed by a programmer: old_help_icon() can not be used any more, please see help_icon(). !!!
             
            Debug info:
            Error code: codingerror
            Stack trace: * line 1881 of \lib\outputrenderers.php: coding_exception thrown
            * line ? of unknownfile: call to core_renderer->old_help_icon()
            * line 1455 of \lib\setuplib.php: call to call_user_func_array()
            * line 6 of \test.php: call to bootstrap_renderer->__call()
            * line 6 of \test.php: call to bootstrap_renderer->old_help_icon()
            

            Show
            Michael de Raadt added a comment - Test result: Yeah, OK. I tested this by running a test script to call the function... $OUTPUT->old_help_icon('asd','asd'); ...and it produced the expected result... !!! Coding error detected, it must be fixed by a programmer: old_help_icon() can not be used any more, please see help_icon(). !!!   Debug info: Error code: codingerror Stack trace: * line 1881 of \lib\outputrenderers.php: coding_exception thrown * line ? of unknownfile: call to core_renderer->old_help_icon() * line 1455 of \lib\setuplib.php: call to call_user_func_array() * line 6 of \test.php: call to bootstrap_renderer->__call() * line 6 of \test.php: call to bootstrap_renderer->old_help_icon()
            Hide
            Eloy Lafuente (stronk7) added a comment -

            This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

            Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

            Thanks, closing as fixed!

            Show
            Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: