Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.6
    • Fix Version/s: 2.3.4
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      I'd advise having your browsers inspector up for these tests

      For master:

      • Open a course
      • Turn editing on
      • Turn off the activity chooser
      • Click the help icon next to the 'Add a resource...' dropdown
      • Confirm:
        • that the Network activity tab in your browser inspector showed a page fetch to help.php
        • that the correct help text is displayed
        • that the correct help title is displayed
      • Click the close button to close the tooltip
        • Confirm that the popup closed
      • Re-open the same help
      • Click elsewhere on the page not a link
        • Confirm that the popup closed
      • Re-open the same help
      • Click on another help icon
      • Confirm:
        • that the Network activity tab in your browser inspector showed a new page fetch to help.php
        • that the correct help text is displayed
        • that the correct help title is displayed
      • Disable JavaScript in your browser
      • Refresh the page
      • Click on the help icon again
        • Confirm that the help opens correctly (not a JS popup)*
      Show
      I'd advise having your browsers inspector up for these tests For master: Open a course Turn editing on Turn off the activity chooser Click the help icon next to the 'Add a resource...' dropdown Confirm: that the Network activity tab in your browser inspector showed a page fetch to help.php that the correct help text is displayed that the correct help title is displayed Click the close button to close the tooltip Confirm that the popup closed Re-open the same help Click elsewhere on the page not a link Confirm that the popup closed Re-open the same help Click on another help icon Confirm: that the Network activity tab in your browser inspector showed a new page fetch to help.php that the correct help text is displayed that the correct help title is displayed Disable JavaScript in your browser Refresh the page Click on the help icon again Confirm that the help opens correctly (not a JS popup)*
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36752-master

      Description

      Although MDL-35819 will completely rewrite tooltip help in Moodle, it cannot be backported and is highly unlikely to hit Moodle 2.4

      This change will improve the (client-side) efficiency of the help tooltip in Moodle. It works in a similar way to the change in MDL-35819 in that we move to an event delegation model rather than individual listeners for each clickable help icon.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13