Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36760

Changes to frozen elements in MDL-30845 broke form validation (was Unit handling for numerical type questions does not work)

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.2.6, 2.3.3
    • 2.2.7, 2.3.4
    • Questions
    • MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_22_STABLE, MOODLE_23_STABLE
    • Hide

      1. Create a numerical question that has the option to use units enabled.

      2. Given that we already missed one regression, consider whether we should do more of the testing that was outlined at http://tracker.moodle.org/browse/MDL-30845#bonfiremodule_heading. Indeed, we may even want to repeat some. For example, it claims there that question editing forms were tested, but that is where this regression was.

      Show
      1. Create a numerical question that has the option to use units enabled . 2. Given that we already missed one regression, consider whether we should do more of the testing that was outlined at http://tracker.moodle.org/browse/MDL-30845#bonfiremodule_heading . Indeed, we may even want to repeat some. For example, it claims there that question editing forms were tested, but that is where this regression was.

    Description

      If units are not used at all, a numerical question can be saved and will work. If Unit Handling is set to 'Units are optional...' or to 'The unit must be given, and will be graded.' the question cannot be saved. Unit 1 will insist 'You must enter a multiplier here.' but will not let you type in the input box. I get the same behavior at qa.moodle.net and on my own 2.4 beta site.

      Attachments

        Issue Links

          blocks

          Functional Test - A test of a single Moodle feature MDLQA-4840 CLONE - A teacher can create, edit and preview a numerical question with required units

          • Passed
          is a regression caused by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-30845 read-only text input fields rendered as plain text and not as a read-only input field

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Functional Test - A test of a single Moodle feature MDLQA-4839 CLONE - A teacher can create, edit and preview a numerical question with optional units

          • Passed

          Activity

            People

              timhunt Tim Hunt
              alrachels AL Rachels
              Adrian Greeve Adrian Greeve
              Sam Hemelryk Sam Hemelryk
              Michael de Raadt Michael de Raadt
              Safat Shahin, Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Jan/13