Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36760

Changes to frozen elements in MDL-30845 broke form validation (was Unit handling for numerical type questions does not work)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.2.6, 2.3.3
    • Fix Version/s: 2.2.7, 2.3.4
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a numerical question that has the option to use units enabled.

      2. Given that we already missed one regression, consider whether we should do more of the testing that was outlined at http://tracker.moodle.org/browse/MDL-30845#bonfiremodule_heading. Indeed, we may even want to repeat some. For example, it claims there that question editing forms were tested, but that is where this regression was.

      Show
      1. Create a numerical question that has the option to use units enabled . 2. Given that we already missed one regression, consider whether we should do more of the testing that was outlined at http://tracker.moodle.org/browse/MDL-30845#bonfiremodule_heading . Indeed, we may even want to repeat some. For example, it claims there that question editing forms were tested, but that is where this regression was.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      If units are not used at all, a numerical question can be saved and will work. If Unit Handling is set to 'Units are optional...' or to 'The unit must be given, and will be graded.' the question cannot be saved. Unit 1 will insist 'You must enter a multiplier here.' but will not let you type in the input box. I get the same behavior at qa.moodle.net and on my own 2.4 beta site.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              alrachels AL Rachels
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Sam Hemelryk
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jan/13