Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36763

Activity indentation on the course page works incorrectly with Chrome.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.3
    • Fix Version/s: 2.3.4
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      • Open a course
      • Turn editing on
      • On an activity currently hard left:
        • Indent right twice
        • Confirm that the activity now has a class 'mod-indent-2'
        • Indent left once
        • Confirm that the activity now has a class 'mod-indent-1'
        • Indent left once more
        • Confirm that the activity now has a class 'mod-indent-0' and is now hard left again
        • Confirm that the 'Move left' icon has been removed
        • Indent the activity right twice again
      • Refresh the page
      • On the same activity:
        • Confirm that the activity now has a class 'mod-indent-2'
        • Indent left once
        • Confirm that the activity now has a class 'mod-indent-1'
        • Indent left once more
        • Confirm that the activity now has a class 'mod-indent-0' and is now hard left again
        • Confirm that the 'Move left' icon has been removed
      Show
      Open a course Turn editing on On an activity currently hard left: Indent right twice Confirm that the activity now has a class 'mod-indent-2' Indent left once Confirm that the activity now has a class 'mod-indent-1' Indent left once more Confirm that the activity now has a class 'mod-indent-0' and is now hard left again Confirm that the 'Move left' icon has been removed Indent the activity right twice again Refresh the page On the same activity: Confirm that the activity now has a class 'mod-indent-2' Indent left once Confirm that the activity now has a class 'mod-indent-1' Indent left once more Confirm that the activity now has a class 'mod-indent-0' and is now hard left again Confirm that the 'Move left' icon has been removed
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36763-master

      Description

      When indenting to the left the indentation will move two spaces instead of one.
      This doesn't happens when indenting right.

      Currently this only happens on Chrome on Ubuntu. (Tested on windows and Mac)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            dobedobedoh Andrew Nicols added a comment -

            Hmm. Well I was able to replicate this, then I started trying to fix it, and then it went away.

            It looks like the move_left() function is called twice for some reason but I can't see why this would be - still looking.

            As you say, this only happens on the left arrow, and not the right.

            Show
            dobedobedoh Andrew Nicols added a comment - Hmm. Well I was able to replicate this, then I started trying to fix it, and then it went away. It looks like the move_left() function is called twice for some reason but I can't see why this would be - still looking. As you say, this only happens on the left arrow, and not the right.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Only happens when you indent right first.

            Show
            dobedobedoh Andrew Nicols added a comment - Only happens when you indent right first.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            There was an eroneous onclick event added when we add the moveleft icon.

            This is no longer required following MDL-34328.

            Show
            dobedobedoh Andrew Nicols added a comment - There was an eroneous onclick event added when we add the moveleft icon. This is no longer required following MDL-34328 .
            Hide
            fred Frédéric Massart added a comment -

            Thanks Andrew. Pushing for integration!

            Show
            fred Frédéric Massart added a comment - Thanks Andrew. Pushing for integration!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Andrew, this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Tested the 23 branch during integration review, MDLQA-4927 will see the master branch tested.

            Show
            samhemelryk Sam Hemelryk added a comment - Tested the 23 branch during integration review, MDLQA-4927 will see the master branch tested.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Y E S !

            Closing as fixed, many thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13