Moodle
  1. Moodle
  2. MDL-34080 Complete overhaul of all standard icons in core
  3. MDL-36765

Course and remote course icons

        Details

        • Type: Sub-task Sub-task
        • Status: Closed
        • Priority: Critical Critical
        • Resolution: Fixed
        • Affects Version/s: 2.4
        • Fix Version/s: 2.4
        • Component/s: Usability
        • Labels:
          None
        • Testing Instructions:
          Hide

          Test pre-requisites

          • A course event in a calendar
          • Combo list and course list on front page (front page settings)
          • Mnet set up to access a remote course

          Test steps

          1. Explore course/index.php and course/category.php
          2. Explore the course event on the calendar
          3. Check the 'Courses' block for the 'Course' and 'Remote course' icons
          4. Make sure:
            • The icons appear nicely
            • The fallback on PNG works (Opera, IE8)
          Show
          Test pre-requisites A course event in a calendar Combo list and course list on front page (front page settings) Mnet set up to access a remote course Test steps Explore course/index.php and course/category.php Explore the course event on the calendar Check the 'Courses' block for the 'Course' and 'Remote course' icons Make sure : The icons appear nicely The fallback on PNG works (Opera, IE8)
        • Affected Branches:
          MOODLE_24_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-36765-master
        • Pull Master Diff URL:

          Description

          Opening a separate issue for those as it appears that Martin was not convinced by the proposed course icon.

          i/courseevent should also be updated.

          This issue could include the revised scale icon.

            Gliffy Diagrams

              Issue Links

              is blocked by

              Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36775 Calendar icon issues

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Frédéric Massart added a comment -

                Those icons can be found in the 'Courses' block. But the course icon can also be found on the front page.

                Show
                Frédéric Massart added a comment - Those icons can be found in the 'Courses' block. But the course icon can also be found on the front page.
                Hide
                Permalink
                Frédéric Massart added a comment -

                Note: The scale icon is not related but has been inserted in this issue by lazyness.

                Show
                Frédéric Massart added a comment - Note: The scale icon is not related but has been inserted in this issue by lazyness.
                Hide
                Permalink
                Jason Fowler added a comment - - edited

                [ ] Syntax
                [ ] Output
                [ ] Whitespace
                [ ] Language
                [ ] Databases
                [ ] Testing
                [ ] Security
                [ ] Documentation
                [ ] Git
                [ ] Sanity check
                [ ] Images

                Good to go!

                Show
                Jason Fowler added a comment - - edited [ ] Syntax [ ] Output [ ] Whitespace [ ] Language [ ] Databases [ ] Testing [ ] Security [ ] Documentation [ ] Git [ ] Sanity check [ ] Images Good to go!
                Hide
                Permalink
                Aparup Banerjee added a comment -

                thanks, thats been integrated into master.

                Show
                Aparup Banerjee added a comment - thanks, thats been integrated into master.
                Hide
                Permalink
                Ankit Agarwal added a comment -

                Works as described.
                Remote course icon is cool somewhat reminds me of steam

                cheers!

                Show
                Ankit Agarwal added a comment - Works as described. Remote course icon is cool somewhat reminds me of steam cheers!
                Hide
                Permalink
                Matteo Scaramuccia added a comment -

                n00b question (don't hit me ): https://github.com/FMCorz/moodle/compare/97df015690...MDL-36765-master#L3R9 seems to miss a run of theme/base/cli/svgtool.php and the same in integration.git: something that will be addressed automatically when the commits will land into moodle.git?

                Show
                Matteo Scaramuccia added a comment - n00b question (don't hit me ): https://github.com/FMCorz/moodle/compare/97df015690...MDL-36765-master#L3R9 seems to miss a run of theme/base/cli/svgtool.php and the same in integration.git : something that will be addressed automatically when the commits will land into moodle.git ?
                Hide
                Permalink
                Frédéric Massart added a comment -

                Hi Matteo, we decided to run that script at the same time as we roll the releases. The tag will be placed in there don't worry . Thanks for your concern.

                Show
                Frédéric Massart added a comment - Hi Matteo, we decided to run that script at the same time as we roll the releases. The tag will be placed in there don't worry . Thanks for your concern.
                Hide
                Permalink
                Matteo Scaramuccia added a comment -

                OK
                TNX Frédéric for taking the time to reply, appreciated!

                Show
                Matteo Scaramuccia added a comment - OK TNX Frédéric for taking the time to reply, appreciated!
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Y E S !

                Closing as fixed, many thanks!

                Show
                Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: