Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.3
    • Fix Version/s: 2.4
    • Component/s: Usability
    • Labels:
    • Testing Instructions:
      Hide

      Test pre-requisites

      • An event of each type on calendar (course, group, user and site)

      Test steps

      1. Browse the calendar and make sure the icons appear nicely
      2. Also check the upcoming events block
        • Test RTL
        • Fallback on PNG icons
        • Consistency in padding/margin, etc...
      Show
      Test pre-requisites An event of each type on calendar (course, group, user and site) Test steps Browse the calendar and make sure the icons appear nicely Also check the upcoming events block Test RTL Fallback on PNG icons Consistency in padding/margin, etc...
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36775-master

      Description

      Calendar icon issues

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Frédéric Massart added a comment -

            Note: I have decide to deprecate the c/ directory. Only the calendar is using those icons which were copy of the icons under i/ (except for c/site). That's why I renamed them to i/fooevent. Also, please note that the courseevent icon is a placeholder and should be approved by Martin in MDL-36765.

            Show
            Frédéric Massart added a comment - Note: I have decide to deprecate the c/ directory. Only the calendar is using those icons which were copy of the icons under i/ (except for c/site). That's why I renamed them to i/fooevent. Also, please note that the courseevent icon is a placeholder and should be approved by Martin in MDL-36765 .
            Hide
            Dan Poltawski added a comment -

            Integrated, thanks guys

            Show
            Dan Poltawski added a comment - Integrated, thanks guys
            Hide
            Mark Nelson added a comment -

            Looks good Freddos in LTR and RTL for both the png and svg icons. Passing.

            Show
            Mark Nelson added a comment - Looks good Freddos in LTR and RTL for both the png and svg icons. Passing.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Y E S !

            Closing as fixed, many thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: