Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Usability
    • Labels:
      None
    • Testing Instructions:
      Hide

      Test pre-requisites

      • Prohibit the permission moodle/backup:backupsection to the teacher role

      Test steps

      1. Login as a teacher
      2. Backup a course
      3. You should see the icon 'permission lock' to store User Data
      4. On other steps, you should see the icon 'hierarchy lock'
      5. Make sure those icons appear nicely and fallback on PNG when using IE8 or Opera
      Show
      Test pre-requisites Prohibit the permission moodle/backup:backupsection to the teacher role Test steps Login as a teacher Backup a course You should see the icon 'permission lock' to store User Data On other steps, you should see the icon 'hierarchy lock' Make sure those icons appear nicely and fallback on PNG when using IE8 or Opera
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36777-master

      Description

      Backup icon issues

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Frédéric Massart added a comment -

            Note: Looking at the code, the icon configlock will never be displayed.

            Show
            Frédéric Massart added a comment - Note: Looking at the code, the icon configlock will never be displayed.
            Hide
            Mark Nelson added a comment -

            Hi Fred, looks good after discussing that the CSS class icon-pre is already defined in another commit. Thanks.

            Show
            Mark Nelson added a comment - Hi Fred, looks good after discussing that the CSS class icon-pre is already defined in another commit. Thanks.
            Hide
            Aparup Banerjee added a comment -

            Thanks guys, this has been integrated now into master.

            note: i've seen some bizarre blurring after SVG scaling and anti-aliasing on my system (and on a remote ie9 vm) for some reason but Fred isn't seeing it. It was suggested that i conclude my systems suck :-p

            Show
            Aparup Banerjee added a comment - Thanks guys, this has been integrated now into master. note: i've seen some bizarre blurring after SVG scaling and anti-aliasing on my system (and on a remote ie9 vm) for some reason but Fred isn't seeing it. It was suggested that i conclude my systems suck :-p
            Hide
            Aparup Banerjee added a comment -

            passed.
            (see comment above for feedback about svg blurring)

            Show
            Aparup Banerjee added a comment - passed. (see comment above for feedback about svg blurring)
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Just in time for Moodle 2.4.0 release, thanks!

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Just in time for Moodle 2.4.0 release, thanks! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: