Moodle

Guest users see lots of error in recent activity page

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.4
  • Fix Version/s: 2.2.7, 2.3.4, 2.4.1
  • Component/s: Course
  • Labels:

Description

  1. Enable guest access in course and site level
  2. Enable recent activity block in course
  3. Goto a course recent activity page as guest
  4. Click 'Show recent activity'
    It is full of undefined variable error as shown in http://ScrnSht.com/lykzqk

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Poltawski added a comment -

Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170

Show
Dan Poltawski added a comment - Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170
Hide
Permalink
Dan Poltawski added a comment -

Its useful to copy and paste the error ankit (makes it more searchable)

Show
Dan Poltawski added a comment - Its useful to copy and paste the error ankit (makes it more searchable)
Hide
Permalink
Dan Poltawski added a comment -

The mform wasn't setting the userid when didn't have permission.

I've made it default to 0 when mform not set to prevent warnings and keep same behaviour.

Requesting peer review.

Show
Dan Poltawski added a comment - The mform wasn't setting the userid when didn't have permission. I've made it default to 0 when mform not set to prevent warnings and keep same behaviour. Requesting peer review.
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Dan,

Patch looks good, pushing for integration review.
[y] Syntax
[y] Output
[y] Whitespace
[-] Language
[-] Databases
[y] Testing
[-] Security
[-] Documentation
[y] Git
[y] Sanity check

Show
Rajesh Taneja added a comment - Thanks Dan, Patch looks good, pushing for integration review. [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Dan, has been integrated now

Show
Sam Hemelryk added a comment - Thanks Dan, has been integrated now
Hide
Permalink
Frédéric Massart added a comment -

Test passed on 2.2, 2.3 and 2.4. Thanks!

Show
Frédéric Massart added a comment - Test passed on 2.2, 2.3 and 2.4. Thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: