Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.4
-
Component/s: Course
-
Labels:
-
Testing Instructions:
- Enable guest access in course and site level
- Enable recent activity block in course
- Goto a course recent activity page as guest
- Click 'Show recent activity'
- No errors should be seen.
-
Affected Branches:MOODLE_24_STABLE
-
Fixed Branches:MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
- Enable guest access in course and site level
- Enable recent activity block in course
- Goto a course recent activity page as guest
- Click 'Show recent activity'
It is full of undefined variable error as shown in http://ScrnSht.com/lykzqk
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Its useful to copy and paste the error ankit (makes it more searchable)
The mform wasn't setting the userid when didn't have permission.
I've made it default to 0 when mform not set to prevent warnings and keep same behaviour.
Requesting peer review.
Thanks Dan,
Patch looks good, pushing for integration review.
[y] Syntax
[y] Output
[y] Whitespace
[-] Language
[-] Databases
[y] Testing
[-] Security
[-] Documentation
[y] Git
[y] Sanity check
Thanks Dan, has been integrated now
Test passed on 2.2, 2.3 and 2.4. Thanks!
Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!
Closing, ciao 
Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170 Notice: Undefined property: stdClass::$user in /Users/danp/git/integration/course/recent.php on line 170