Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.3
    • Fix Version/s: 2.4
    • Component/s: Usability
    • Labels:
    • Testing Instructions:
      Hide

      Test pre-requisites

      • Enable the unread post tracking
      • For the student edit their profile and set 'Forum tracking' to 'Yes: highlight new posts for me'
      • Create some posts using a different account on a forum

      Test steps

      1. Login and visit the forum's page (and the forum/index.php page)
      2. Make sure the icon look nice and the fallback to PNG works as expected
      Show
      Test pre-requisites Enable the unread post tracking For the student edit their profile and set 'Forum tracking' to 'Yes: highlight new posts for me' Create some posts using a different account on a forum Test steps Login and visit the forum's page (and the forum/index.php page) Make sure the icon look nice and the fallback to PNG works as expected
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36782-master

      Description

      Unread icon for forums

      t/clear, should be 12x12. Could be renamed to something that makes more sense, such as 'markasread'.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              Hi Fred,

              This is conflicting on LTI.

              Show
              poltawski Dan Poltawski added a comment - Hi Fred, This is conflicting on LTI.
              Hide
              fred Frédéric Massart added a comment -

              Hi Dan, conflict fixed. Thanks!

              Show
              fred Frédéric Massart added a comment - Hi Dan, conflict fixed. Thanks!
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated, thanks Fred.

              Show
              poltawski Dan Poltawski added a comment - Integrated, thanks Fred.
              Hide
              markn Mark Nelson added a comment -

              Hi Fred, there was no spacing after 'Unread' and the tick.

              Show
              markn Mark Nelson added a comment - Hi Fred, there was no spacing after 'Unread' and the tick.
              Hide
              fred Frédéric Massart added a comment -

              Thanks Mark, pushed a new commit to fix that missing margin. Cheers!

              Show
              fred Frédéric Massart added a comment - Thanks Mark, pushed a new commit to fix that missing margin. Cheers!
              Hide
              poltawski Dan Poltawski added a comment -

              pulled.

              Show
              poltawski Dan Poltawski added a comment - pulled.
              Hide
              markn Mark Nelson added a comment -

              Great work Fred! Simply amazing, superb, fantastic, mesmerising. Such awesome work. I feel like crying. Passing.

              Show
              markn Mark Nelson added a comment - Great work Fred! Simply amazing, superb, fantastic, mesmerising. Such awesome work. I feel like crying. Passing.
              Hide
              fred Frédéric Massart added a comment -

              Thank Barbara

              Show
              fred Frédéric Massart added a comment - Thank Barbara
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Y E S !

              Closing as fixed, many thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12