Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.6
-
Component/s: Workshop
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_22_STABLE
-
Fixed Branches:MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-36805-master -
Pull Master Diff URL:
Description
As discussed in MDL-34791, workshop_grade_item_update() takes $workshop as a parameter.
The phpDoc block suggests that modname should be present in this stdClass object, but it's never used and is not in fact required.
Gliffy Diagrams
Attachments
Issue Links
- Testing discovered
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Thanks Andrew,
Just had a word with Dan and it seems it can be backported as this is wrong documentation.
Otherwise patch looks nice, I would probably remove "with extra cmidnumber property", as workshop instance is expected to have id.
Cheers Raj,
I'll backport this too. The cmidnumber is a field which must be added to the object from another table so this comment does make sense. The same comment is included in every module providing this functionality.
Andrew
Backported to 22 and 23. Since we're still on sync, I've not provided a 24 branch.
Thanks Andrew, this has been integrated now.
By total coincidence I had been looking at the grade API this morning in relation to the grade_update callback and how it functions.
Passing as no testing required, confirmed during review.
Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!
Closing, ciao 
I haven't provided a MOODLE_23_STABLE branch - not sure whether this should be backported or not. If someone could advise, then I'll happily create one (though it should cherry-pick cleanly)