Moodle

Enabling grade_report_fixedstudents, shows the user's list on the left side of the page, in RTL mode (theme/standard)

Details

  • Testing Instructions:
    Hide
    1. Switch language to Hebrew (or any RTL language)
    2. As Admin, Enable grade_report_fixedstudents
    3. Navigate into any course which has some users enrolled and some activities available
    4. Open the course's grader report and see that the user's list is right aligned (as seen in the second attached screen capture)
    Show
    Switch language to Hebrew (or any RTL language) As Admin, Enable grade_report_fixedstudents Navigate into any course which has some users enrolled and some activities available Open the course's grader report and see that the user's list is right aligned (as seen in the second attached screen capture)
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    WIP-MDL-36812-master
  • Pull Master Diff URL:

Description

Fixed user's list in course grader report should be right aligned in RTL mode (in theme/standard)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mary Evans added a comment -

Looks OK to me Nadav so submitting this for integration.

Show
Mary Evans added a comment - Looks OK to me Nadav so submitting this for integration.
Hide
Permalink
Sam Hemelryk added a comment -

Sorry about the noise forget to set currently in integration to yes and had to restart this.

Show
Sam Hemelryk added a comment - Sorry about the noise forget to set currently in integration to yes and had to restart this.
Hide
Permalink
Sam Hemelryk added a comment -

Hi Nadav, just a quick check, this has a fixed version of 2.3, would you like me to backport it to 23 and 24?

Show
Sam Hemelryk added a comment - Hi Nadav, just a quick check, this has a fixed version of 2.3, would you like me to backport it to 23 and 24?
Hide
Permalink
Nadav Kavalerchik added a comment -

Thanks Sam, but no need. I will fix it. (better spent your precious time on other important issues )

Show
Nadav Kavalerchik added a comment - Thanks Sam, but no need. I will fix it. (better spent your precious time on other important issues )
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Nadav, this has been integrated now and cherry-picked to all branches.

Show
Sam Hemelryk added a comment - Thanks Nadav, this has been integrated now and cherry-picked to all branches.
Hide
Permalink
Nadav Kavalerchik added a comment -

Bless you

Show
Nadav Kavalerchik added a comment - Bless you
Hide
Permalink
Adrian Greeve added a comment -

Tested on the 2.2, 2.3, 2.4 and master integration branches.
My pages matched the fixed image that is attached to this issue.
Test passed.

Show
Adrian Greeve added a comment - Tested on the 2.2, 2.3, 2.4 and master integration branches. My pages matched the fixed image that is attached to this issue. Test passed.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Changes are now upstream, thanks for your collaboration!

If you are going to have any celebration next days, enjoy with your gang, if not, too!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Changes are now upstream, thanks for your collaboration! If you are going to have any celebration next days, enjoy with your gang, if not, too! Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: