Moodle
  1. Moodle
  2. MDL-36819

Add new interface for configurable cache store plugins.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Browse to Admin > Plugins > Caching > Configuration
      3. Add an instance of the file store with the name "Test file store" and default setting.
      4. Edit the file store and make sure that it has the default settings and the correct name.
      5. Change the default settings, marking single directory store and prescan.
      6. Save the changes
      7. Go back and edit the store.
      8. Make sure those two settings are still checked.
      Show
      Log in as an admin Browse to Admin > Plugins > Caching > Configuration Add an instance of the file store with the name "Test file store" and default setting. Edit the file store and make sure that it has the default settings and the correct name. Change the default settings, marking single directory store and prescan. Save the changes Go back and edit the store. Make sure those two settings are still checked.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-36819-m24
    • Rank:
      46340

      Description

      This would be a HUGE improvement in regards to self documenting cache stores plugins that are configurable and is more in line with the rest of the cache API design.

        Activity

        Hide
        Sam Hemelryk added a comment -

        Putting this up for integration review immediately.

        This is a minor change but one that I think makes very good sense.

        If this change makes it into 2.4 by some miracle then sweet, if not I will change the patches after release to support the old method checking and display a debug notice.

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Putting this up for integration review immediately. This is a minor change but one that I think makes very good sense. If this change makes it into 2.4 by some miracle then sweet, if not I will change the patches after release to support the old method checking and display a debug notice. Many thanks Sam
        Hide
        Sam Hemelryk added a comment -

        Hi Eloy, added you as a watcher here, as the reviewer of MUC this will likely make instant sense to you

        Show
        Sam Hemelryk added a comment - Hi Eloy, added you as a watcher here, as the reviewer of MUC this will likely make instant sense to you
        Hide
        Sam Hemelryk added a comment -

        MDL-36768 is likely to land, because this change will conflict with that one I have produced a branch based upon it that can be used for integration.

        For reference the only branch was:

        wip-MDL-36819-m24

        The branch based upon MDL-36768 is:

        wip-MDL-36819-m24-rb

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - MDL-36768 is likely to land, because this change will conflict with that one I have produced a branch based upon it that can be used for integration. For reference the only branch was: wip- MDL-36819 -m24 The branch based upon MDL-36768 is: wip- MDL-36819 -m24-rb Many thanks Sam
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Sam Hemelryk added a comment -

        Thanks Eloy, much appreciated

        Show
        Sam Hemelryk added a comment - Thanks Eloy, much appreciated
        Hide
        David Monllaó added a comment -

        It works as expected.

        Show
        David Monllaó added a comment - It works as expected.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Y E S !

        Closing as fixed, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: