Moodle
  1. Moodle
  2. MDL-36841

Exporting content to a portfolio using Leap2a triggers strict standards error.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.6, 2.3.3, 2.4
    • Fix Version/s: 2.2.7, 2.3.4
    • Component/s: Portfolio API
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Create a Mahara site and link it to Moodle using SSO (read https://wiki.mahara.org/images/d/d5/Mahoodle.pdf to see how).
      2. Create a forum activity in a course.
      3. Add a discussion with an attachment.
      4. Visit the forum activity as a student and click to export the discussion to your portfolio.
      5. Ensure you do not see the following error -

      Note: please test this on stables.

      Strict Standards: Declaration of portfolio_format_leap2a_file::add_extra_links() should be compatible with that of portfolio_format_leap2a_entry::add_extra_links() in /var/www/mstorage/im/moodle/lib/portfolio/formats/leap2a/lib.php on line 529

      Show
      Create a Mahara site and link it to Moodle using SSO (read https://wiki.mahara.org/images/d/d5/Mahoodle.pdf to see how). Create a forum activity in a course. Add a discussion with an attachment. Visit the forum activity as a student and click to export the discussion to your portfolio. Ensure you do not see the following error - Note: please test this on stables. Strict Standards: Declaration of portfolio_format_leap2a_ file::add_extra_links( ) should be compatible with that of portfolio_format_leap2a_entry::add_extra_links() in /var/www/mstorage/im/moodle/lib/portfolio/formats/leap2a/lib.php on line 529
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36841_master
    • Rank:
      46363

      Description

      1. Create a Mahara site and link it to Moodle using SSO (read https://wiki.mahara.org/images/d/d5/Mahoodle.pdf to see how).
      2. Create a forum activity in a course.
      3. Add a discussion with an attachment.
      4. Visit the forum activity as a student and click to export the discussion to your portfolio.
      5. You should be given the following error -

      Strict Standards: Declaration of portfolio_format_leap2a_file::add_extra_links() should be compatible with that of portfolio_format_leap2a_entry::add_extra_links() in /var/www/mstorage/im/moodle/lib/portfolio/formats/leap2a/lib.php on line 529

        Issue Links

          Activity

          Hide
          Rajesh Taneja added a comment -

          Patch looks good Mark,

          Please re-base and add test instructions before pushing for integration.

          Show
          Rajesh Taneja added a comment - Patch looks good Mark, Please re-base and add test instructions before pushing for integration.
          Hide
          Mark Nelson added a comment -

          Thanks Raj. I was actually rebasing my commit, then I clicked on 'Request peer review' and was given an error that I had chosen an invalid action. I then refreshed the page to see it had already been peer reviewed lol!

          Show
          Mark Nelson added a comment - Thanks Raj. I was actually rebasing my commit, then I clicked on 'Request peer review' and was given an error that I had chosen an invalid action. I then refreshed the page to see it had already been peer reviewed lol!
          Hide
          Aparup Banerjee added a comment -

          i've integrated this into 22, 23 and master.

          about backporting this..
          ps: this could be seen as an api change (rule 1:don't back port api changes) but just noting that it seemed really isolated case. so my bad if this breaks for any stable out there.
          (if i had thought about it before pushing though i might've avoided backporting possibly)

          Show
          Aparup Banerjee added a comment - i've integrated this into 22, 23 and master. about backporting this.. ps: this could be seen as an api change (rule 1:don't back port api changes) but just noting that it seemed really isolated case. so my bad if this breaks for any stable out there. (if i had thought about it before pushing though i might've avoided backporting possibly)
          Hide
          Ankit Agarwal added a comment -

          I and Mark did some testing on this and it doesnt throw error any more.
          passing
          Thanks

          Show
          Ankit Agarwal added a comment - I and Mark did some testing on this and it doesnt throw error any more. passing Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Y E S !

          Closing as fixed, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: