Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36855

Undefined offset errors in Scorm interactions Report

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: None
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      Test pre-requisites

      • Moodle install with a new scorm activity with the attached scorm pack
      • A few students in course
      • Donot enter scorm or make any attempts

      Test steps

      1. Login as admin , and goto scorm>report>interaction report
      2. Make sure no errors are seen
      3. Change preferences and tick questions, response, correct answer and save
      4. make sure no error is there
      5. Make sure
      Show
      Test pre-requisites Moodle install with a new scorm activity with the attached scorm pack A few students in course Donot enter scorm or make any attempts Test steps Login as admin , and goto scorm>report>interaction report Make sure no errors are seen Change preferences and tick questions, response, correct answer and save make sure no error is there Make sure
    • Affected Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-36855-master

      Description

      Notice the following errors while testing MDLQA-4683:

      Notice: Undefined offset: 23 in /integration/master/lib/tablelib.php on line 983
       
      Notice: Undefined index: in /integration/master/lib/tablelib.php on line 986
       
      Notice: Undefined index: in /integration/master/lib/tablelib.php on line 996
       
      Notice: Undefined index: in /integration/master/lib/tablelib.php on line 997

      Steps to replicate:

      1. Create a scorm activity with the attached scorm package.
      2. Select 'interactions report' from the reports tab.

      Notice the above error.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            danmarsden Dan Marsden added a comment -

            Thanks - adding Ankit here - this looks like it's coming from your interactions report - do you want to take a look - if not leave it here and I'll get to it at some point.

            Show
            danmarsden Dan Marsden added a comment - Thanks - adding Ankit here - this looks like it's coming from your interactions report - do you want to take a look - if not leave it here and I'll get to it at some point.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Thanks Dan,
            Since this not a QA issue, I will look into it during the next sprint.
            Thanks

            Rosie,
            Can you please attach the scorm pack you used and let me know if you did anything besides making normal attempts. Since am not able to replicate this.

            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Thanks Dan, Since this not a QA issue, I will look into it during the next sprint. Thanks Rosie, Can you please attach the scorm pack you used and let me know if you did anything besides making normal attempts. Since am not able to replicate this. Thanks
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Hi Ankit,

            The changes look great.

            [y] Syntax
            [y] Output
            [y] Whitespace
            [-] Language
            [-] Databases
            [y] Testing (master only)
            [-] Security
            [-] Documentation
            [y] Git
            [y] Sanity check

            +1 for integration.

            Show
            rwijaya Rossiani Wijaya added a comment - Hi Ankit, The changes look great. [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing (master only) [-] Security [-] Documentation [y] Git [y] Sanity check +1 for integration.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Thanks for the review Rosie,
            Sending for integration
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Thanks for the review Rosie, Sending for integration Thanks
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Ankit this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Ankit this has been integrated now.
            Hide
            dmonllao David Monllaó added a comment -

            It passes, tested in 23 and master with the provided SCORM package

            Show
            dmonllao David Monllaó added a comment - It passes, tested in 23 and master with the provided SCORM package
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And your fantastic code has met core, hope they become good friends for a long period.

            Closing, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And your fantastic code has met core, hope they become good friends for a long period. Closing, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: