Moodle
  1. Moodle
  2. MDL-36856

Feedback files upload ends up with fatal error for blind marking assignments

    Details

    • Testing Instructions:
      Hide
      1. Create an assignment in a course with more than one student, with "Blind marking" set to "Yes", "File submissions" set to "Yes", "File feedback" set to "Yes" and "Offline grading worksheet" set to "Yes".
      2. Login as a student and upload a file submission to the assignment
      3. Login as a teacher and go to "View/grade all submissions"
      4. Choose "Download grading worksheet" from the menu above the grading table.
      5. Verify that you download a valid csv file with one row for each student in the assignment
      6. Choose "Upload grading worksheet" from the same menu
      7. Upload the previously downloaded csv file
      8. Verify you see a message "No modified grades found in uploaded worksheet" with a cancel button and not an error or a blank page.
      9. Click cancel to return to the grading table for the assignment
      10. Choose "Download all submissions" from the menu above the grading table. Save the zip.
      11. Open the zip file, make a change to the first submission file in the zip and create a new zip containing only the modified file.
      12. Choose "Upload multiple feedback files in a zip" from the menu above the grading table.
      13. Upload the new zip file that was just created.
      14. Verify you see a page with one new feedback file listed for the student and not an error or a blank page.
      Show
      Create an assignment in a course with more than one student, with "Blind marking" set to "Yes", "File submissions" set to "Yes", "File feedback" set to "Yes" and "Offline grading worksheet" set to "Yes". Login as a student and upload a file submission to the assignment Login as a teacher and go to "View/grade all submissions" Choose "Download grading worksheet" from the menu above the grading table. Verify that you download a valid csv file with one row for each student in the assignment Choose "Upload grading worksheet" from the same menu Upload the previously downloaded csv file Verify you see a message "No modified grades found in uploaded worksheet" with a cancel button and not an error or a blank page. Click cancel to return to the grading table for the assignment Choose "Download all submissions" from the menu above the grading table. Save the zip. Open the zip file, make a change to the first submission file in the zip and create a new zip containing only the modified file. Choose "Upload multiple feedback files in a zip" from the menu above the grading table. Upload the new zip file that was just created. Verify you see a page with one new feedback file listed for the student and not an error or a blank page.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
    • Rank:
      46382

      Description

      1. Create a file assignment with blind marking enabled, feedback files enabled.
      2. Navigate to the assignment, View/grade all submissions.
      3. Select 'Upload multiple feedback files in a zip'.
      4. Select a zip file with feedbacks and click 'Import feedback file(s)'.
      5. You'll see a blank screen with the following PHP fatal error in the error_log:

      PHP Fatal error: Call to undefined method assign::get_unique_id_for_user() in

      {moodle_url}

      /mod/assign/feedback/file/importzipform.php on line 88

      Cause: method name misspelled in feedback/file/importzipform.php

      Investigation showed that the same error will appear when uploading grades to an offline blind marking assignment.

      Will provide with a merge branch shortly.

        Issue Links

          Activity

          Hide
          Kirill Astashov added a comment -

          Providing with a pull branch.

          Show
          Kirill Astashov added a comment - Providing with a pull branch.
          Hide
          Damyon Wiese added a comment -

          [Y] Syntax
          [Y] Output
          [Y] Whitespace
          [Y] Language
          [-] Databases
          [Y] Testing
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          Thanks Kirill,

          I added testing instructions for this patch but everything else looks good.

          Cheers - Damyon

          Show
          Damyon Wiese added a comment - [Y] Syntax [Y] Output [Y] Whitespace [Y] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Thanks Kirill, I added testing instructions for this patch but everything else looks good. Cheers - Damyon
          Hide
          Dan Poltawski added a comment -

          Integrated to master and 24, thanks Kirill

          Show
          Dan Poltawski added a comment - Integrated to master and 24, thanks Kirill
          Hide
          Adrian Greeve added a comment -

          Tested on the master integration branch. I didn't come across any errors.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested on the master integration branch. I didn't come across any errors. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: