Moodle
  1. Moodle
  2. MDL-36859

Remove 'not implemented' cache definitions before release

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Caching
    • Labels:
    • Rank:
      46386

      Description

      Hi Sam,

      We don't have 'config' cache in use, and its shown in the cache UI, so I was wondering if it'd be less 'misleading' if we remove this from lib/db/caches.php before release so it doesn't look like there is a cache on the config table and people start configuring their sites wondering why its not working.

        Activity

        Hide
        Sam Hemelryk added a comment -

        Yes, good thinking thanks Dan.

        Those definitions were left in there originally in order to avoid conflicts when we integrated the conversions themselves.
        Now that config has been delayed best we remove it and revert this when it is integrated.

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Yes, good thinking thanks Dan. Those definitions were left in there originally in order to avoid conflicts when we integrated the conversions themselves. Now that config has been delayed best we remove it and revert this when it is integrated. Many thanks Sam
        Hide
        Sam Hemelryk added a comment -

        Forgot to mention this is up for integration review now

        Show
        Sam Hemelryk added a comment - Forgot to mention this is up for integration review now
        Hide
        Dan Poltawski added a comment -

        Thanks Sam, i've integrated this now

        Show
        Dan Poltawski added a comment - Thanks Sam, i've integrated this now
        Hide
        Dan Poltawski added a comment -

        Looks good here, thanks Sam

        Show
        Dan Poltawski added a comment - Looks good here, thanks Sam
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Y E S !

        Closing as fixed, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: