Moodle
  1. Moodle
  2. MDL-36865

Filepicker arrow displays to the right in Opera, Safari and IE10

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3.3, 2.4
    • Fix Version/s: 2.3.4
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide
      1. Visit a course.
      2. Choose to add a file resource (uses filemanager).
      3. Check that the drag 'n' drop arrow displays correctly in all support browsers.
      4. Choose to add a SCORM (uses filepicker).
      5. Check that the drag 'n' drop arrow displays correctly in all support browsers.
      Show
      Visit a course. Choose to add a file resource (uses filemanager). Check that the drag 'n' drop arrow displays correctly in all support browsers. Choose to add a SCORM (uses filepicker). Check that the drag 'n' drop arrow displays correctly in all support browsers.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36865_master
    • Rank:
      46392

      Description

      The fix for MDL-35760 changed the CSS that was used for both the filemanager and filepicker, however only the spans were changed to divs for the filemanager, not the filepicker, so the arrow now displays to the far right in FF (and I assume other browsers).

        Issue Links

          Activity

          Hide
          Mark Nelson added a comment -

          This change is almost identical to MDL-35760 so bypassing Peer review.

          Show
          Mark Nelson added a comment - This change is almost identical to MDL-35760 so bypassing Peer review.
          Hide
          Aparup Banerjee added a comment -

          Thanks Mark, this has been integrated now.

          Show
          Aparup Banerjee added a comment - Thanks Mark, this has been integrated now.
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          Tested in 2.3 and master on FF, IE10, Chrome, Opera12 and Safari 6 (thanks to Dan P).

          Show
          Michael de Raadt added a comment - Test result: Success! Tested in 2.3 and master on FF, IE10, Chrome, Opera12 and Safari 6 (thanks to Dan P).
          Hide
          Helen Foster added a comment -

          Removing the mdlqa label which I guess was added by mistake, since there is no linked MDLQA test.

          Show
          Helen Foster added a comment - Removing the mdlqa label which I guess was added by mistake, since there is no linked MDLQA test.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Y E S !

          Closing as fixed, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: