Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Usability
    • Labels:
      None
    • Testing Instructions:
      Hide
      • To be tested with supported browsers and IE8 (or Opera) for PNG fallback.
      • Note: both icons are the same, but have different file names.
      1. Check the icon 'Assign roles' in blocks when editing mode
      2. Check the icon 'Assign roles' in the navigation block (Course admin > Users > Enrolled users)
      3. Check the icon 'Enrol users' in the navigation block (Course admin > Users > Other users)
      4. Check the icon 'Enrol users' in the course list page (Home ► Courses ► Miscellaneous ► Add/edit courses)
      Show
      To be tested with supported browsers and IE8 (or Opera) for PNG fallback. Note: both icons are the same, but have different file names. Check the icon 'Assign roles' in blocks when editing mode Check the icon 'Assign roles' in the navigation block (Course admin > Users > Enrolled users) Check the icon 'Enrol users' in the navigation block (Course admin > Users > Other users) Check the icon 'Enrol users' in the course list page (Home ► Courses ► Miscellaneous ► Add/edit courses)
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36869-master
    • Rank:
      46397

      Description

      Revised icons enrolusers and assignroles

        Activity

        Hide
        Frédéric Massart added a comment -

        Pushing straight for integration as straight forward and approved by Martin.

        Show
        Frédéric Massart added a comment - Pushing straight for integration as straight forward and approved by Martin.
        Hide
        Aparup Banerjee added a comment -

        this has been integrated.

        note about preserve tags being removed here from Fred:

        Oh that's Dan's fault, he ran the script on the SVG icons, but then Barbara had to redesign them
        Hence the tag which was removed
        The tag will be put back on release

        Show
        Aparup Banerjee added a comment - this has been integrated. note about preserve tags being removed here from Fred: Oh that's Dan's fault, he ran the script on the SVG icons, but then Barbara had to redesign them Hence the tag which was removed The tag will be put back on release
        Hide
        Frédéric Massart added a comment -

        Yeah well, I didn't mean "Dan's fault". What I meant to say was that Dan had run the script, and the icon had to be updated afterwards. Sorry :-/.

        Show
        Frédéric Massart added a comment - Yeah well, I didn't mean "Dan's fault". What I meant to say was that Dan had run the script, and the icon had to be updated afterwards. Sorry :-/.
        Hide
        Jason Fowler added a comment -

        Works fine in IE8 and Firefox 17

        Show
        Jason Fowler added a comment - Works fine in IE8 and Firefox 17
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Y E S !

        Closing as fixed, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: