Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36887

Some quiz/question related upgrade.txt's are in unconventional order

    Details

    • Testing Instructions:
      Hide
      1. Read the following upgrade.txts and ensure they are 'newest verison at the top.

      mod/quiz/accessrule/upgrade.txt
      question/behaviour/upgrade.txt
      question/format/upgrade.txt

      Show
      Read the following upgrade.txts and ensure they are 'newest verison at the top. mod/quiz/accessrule/upgrade.txt question/behaviour/upgrade.txt question/format/upgrade.txt
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      The standard seems to be to put the latest version at the top of the file (makes sense if you are looking at the file), but a few are not consistent with that. I corrected portfolio quickly, as it applied to 2.4, but there are some in quiz/question:

      Just noticed while I was examining the upgrade.txt's a few which

      git grep '== 2.' -- '*/upgrade.txt'
       
      mod/quiz/accessrule/upgrade.txt:=== 2.2 ===
      mod/quiz/accessrule/upgrade.txt:=== 2.3 ===
      mod/quiz/accessrule/upgrade.txt:=== 2.4 ===
       
      question/behaviour/upgrade.txt:=== 2.2 ===
      question/behaviour/upgrade.txt:=== 2.3 ===
       
      question/format/upgrade.txt:=== 2.1.5 / 2.2.3 / 2.3 ===
      question/format/upgrade.txt:=== 2.2 ===
      question/format/upgrade.txt:=== 2.3 ===
      question/format/upgrade.txt:=== 2.1.5 / 2.2.3 / 2.3 ===
      question/format/upgrade.txt:=== 2.2 ===
      question/format/upgrade.txt:=== 2.3 ===

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            Yes. Please fix. Most recent at the top is obviously best, and it certainly should be consistent.

            Show
            timhunt Tim Hunt added a comment - Yes. Please fix. Most recent at the top is obviously best, and it certainly should be consistent.
            Hide
            poltawski Dan Poltawski added a comment -

            In the question/format/upgrade.txt, i've left the '2.1.5 / 2.2.3 / 2.3' below 2.3, since its sort of 'below'.

            Show
            poltawski Dan Poltawski added a comment - In the question/format/upgrade.txt, i've left the '2.1.5 / 2.2.3 / 2.3' below 2.3, since its sort of 'below'.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Dan, has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Dan, has been integrated now
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested on the 2.3 and master integration branches.
            The newest versions are now at the top of the file.
            Test passed.

            Show
            abgreeve Adrian Greeve added a comment - Tested on the 2.3 and master integration branches. The newest versions are now at the top of the file. Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13