Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36900

"Create folder" dialog closes without error message in file manager when no folder name is given

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.3
    • Fix Version/s: 2.5
    • Component/s: Filepicker
    • Testing Instructions:
      Hide
      1. Go to your private files
      2. Click new folder
        • Make sure the textbox displays "New folder"
        • Make sure the text is selected
        • Hit enter and make sure the folder is created
      3. Click new folder again
        • Make sure the textbox displays "New folder (1)"
        • Click "Create" and make sure the folder is created
      4. Click new folder again
        • Make sure the textbox displays "New folder (2)"
        • Delete the content of the textbox
        • Make sure the 'Create' button is disabled
        • Make sure hitting 'Enter' key does not do anything

      Drag and Drop

      1. Upload a file to your private files via drag and drop (say test.txt)
      2. Upload the same file via drag and drop
      3. Make sure the file name of the newly uploaded file is 'test (1).txt'
      Show
      Go to your private files Click new folder Make sure the textbox displays "New folder" Make sure the text is selected Hit enter and make sure the folder is created Click new folder again Make sure the textbox displays "New folder (1)" Click "Create" and make sure the folder is created Click new folder again Make sure the textbox displays "New folder (2)" Delete the content of the textbox Make sure the 'Create' button is disabled Make sure hitting 'Enter' key does not do anything Drag and Drop Upload a file to your private files via drag and drop (say test.txt) Upload the same file via drag and drop Make sure the file name of the newly uploaded file is 'test (1).txt'
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36900-master

      Description

      When using the "Create folder" dialog in the file manager, if one clicks on the "Create folder" button without first providing a folder name the dialog is hidden and process cancelled. It would be preferable if the user received an error message similar to that during the folder rename process if no name is provided.

      Reproduction steps:

      1. Click on the "Create folder" link in the file manager (anywhere - private files, File Resource modedit, etc)
      2. Leave the "Enter a name:" text box empty or add spaces, but no other characters
      3. Click the "Create folder" button

      Actual result: New folder creation dialog automatically closes when user clicks "Create folder" button without entering the folder name.
      Expected Result: User should be alerted with appropriate message when folder name not entered and clicks on Create folder button.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              sbc24 Sam Chaffee
              Peer reviewer:
              Marina Glancy
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13